Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR changes a file inside |
This was referenced Sep 16, 2026
estebank
force-pushed
the
duplicated-items
branch
from
September 16, 2026 03:05
d1afad9 to
fb93a90
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
duplicated-items
branch
from
September 16, 2026 19:06
fb93a90 to
9cc7001
Compare
Duplicated items cause lots of confusing knock down errors. This change side-steps some known ICEs, and reduces the verbosity of crates with duplicated items at the cost of not emitting every error that we could.
120873 -> `tests/ui/resolve/multiple_definitions_attribute_merging.rs`
(already existing)
123690 -> `tests/ui/resolve/duplicated-enum-variant.rs`
155482 -> `tests/ui/resolve/duplicated-item-in-const-generics.rs`
Added two cases from the report that still ICE.
estebank
force-pushed
the
duplicated-items
branch
from
September 16, 2026 19:16
9cc7001 to
dd5e174
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicated items cause lots of confusing knock down errors. This change side-steps some known ICEs, and reduces the verbosity of crates with duplicated items at the cost of not emitting every error that we could.
Noticed just how problematic these can be while looking at #160695, as
#[derive]s are particularly prone to the kind of confusion these duplicates cause.Fix #120873, fix #123690.
r? @petrochenkov