Rename the src install build step to rust-src. by davidv1992 · Pull Request #162423 · rust-lang/rust

davidv1992 · 2026-09-07T12:17:59Z

This avoids installing the src component from the command line also triggering installing a whole lot of other things which are behind the src path. Furthermore, it makes the name match the component as distributed in rustup, reducing confusion.

rustbot · 2026-09-07T12:18:03Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: bootstrap
bootstrap expanded to 6 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

Mark-Simulacrum

This also should be documented in the bootstrap changelog (https://github.com/rust-lang/rust/blob/20d35a3ae8f310f2a002e5f6e0bc583830010cd4/src/bootstrap/src/utils/change_tracker.rs). I don't think we support a good way to soft-deprecate so probably just changing this is OK? I'll mark @rustbot label +relnotes, so we can call it out as a compatibility note though.

View changes since this review

Mark-Simulacrum · 2026-09-13T22:52:00Z


    fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
-        run.path("src")
+        run.alias("rust-src")


I think this will break

rust/src/bootstrap/mk/Makefile.in

Line 107 in 20d35a3

SKIP_SRC := --skip=src

-- can you fix that up? And look for some other cases of it.

Fixed it, and fixed the remaining 4 occurrences I could find. I have taken the approach of everywhere src is used, it is intentional that rust-src is included, but given the size of the src directory, this may not always be the case, so if someone with more domain knowledge can take a look that would be great.

rustbot · 2026-09-13T22:53:37Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-09-13T22:53:38Z

Error: Unknown labels: a, as, call, can, compatibility, it, note, out, so, though, we

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

rustbot · 2026-09-16T07:43:47Z

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

davidv1992 · 2026-09-16T07:49:49Z

Since rustbot added you into the conversation: @jieyouxu, there is technically a change to a default value in the bootstrap configuration, as rust-src is now its own thing rather than part of src. However, the default behavior of build.tools does not change, rust-src is built when extended=true in both the old and new situation. Should I still add an entry to CONFIG_CHANGE_HISTORY?

davidv1992 · 2026-09-16T07:50:19Z

@rustbot ready

jieyouxu · 2026-09-16T07:57:26Z

I think that can't hurt, just in case. (Also that cc is actually for the CI changes not the bootstrap changes, but yeah anyway 😆)

davidv1992 · 2026-09-16T08:02:41Z

Ok, Added the entry as a warning.

jieyouxu · 2026-09-16T08:04:32Z

@@ -324,12 +324,12 @@ impl CommandLineStep for Src {
    const IS_HOST: bool = true;

    fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
-        run.path("src")
+        run.alias("rust-src")


cc @Kobzol as well, in case you know of an edge case for this alias.

EDIT: ah, but this is an install alias, which I am much less worried about (as opposed to build/dist aliases).

View changes since the review

Left some comments. I think that @Mark-Simulacrum's comment wasn't correct.

…k-simulacrum,jieyouxu,kobzol Rename the src install build step to rust-src. This avoids installing the src component from the command line also triggering installing a whole lot of other things which are behind the src path. Furthermore, it makes the name match the component as distributed in rustup, reducing confusion.

…uwer Rollup of 15 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162423 (Rename the src install build step to rust-src.) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #162832 (add `Div` and `Mul` for `Complex<{float}>`) - #161005 (fix: unfulfilled nested dead code lint) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound)

…k-simulacrum,jieyouxu,kobzol Rename the src install build step to rust-src. This avoids installing the src component from the command line also triggering installing a whole lot of other things which are behind the src path. Furthermore, it makes the name match the component as distributed in rustup, reducing confusion.

…uwer Rollup of 15 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162423 (Rename the src install build step to rust-src.) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #161005 (fix: unfulfilled nested dead code lint) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound)

jieyouxu · 2026-09-18T15:34:27Z

One moment.
@bors r-
@bors try jobs=test_x86_64-fuchsia

Rename the src install build step to rust-src. try-job: test_x86_64-fuchsia

jieyouxu · 2026-09-18T15:36:17Z

@bors try jobs=test-x86_64-fuchsia

Rename the src install build step to rust-src. try-job: test-x86_64-fuchsia

jieyouxu · 2026-09-18T15:39:04Z

@bors rollup=never note="modifies ./x install logic"

rust-bors · 2026-09-18T15:59:28Z

💔 Test for bc11f45 failed: CI. Failed job:

try - test-x86_64-fuchsia (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-09-18T16:11:36Z

The job test-x86_64-fuchsia failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


##[endgroup]
[TIMING:end] install::Docs { build_compiler: Compiler { stage: 1, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.111
Build completed successfully in 0:14:01
+ find /checkout/obj/install/lib/rustlib/aarch64-unknown-fuchsia/lib /checkout/obj/install/lib/rustlib/riscv64gc-unknown-fuchsia/lib /checkout/obj/install/lib/rustlib/x86_64-unknown-fuchsia/lib -type f -name '*.so' -exec sh -c $'/usr/local/bin/llvm-objcopy --only-keep-debug "$1" "$1.debug" && \\\n        /usr/local/bin/llvm-objcopy --strip-all --keep-section=.rustc "$1"' _ '{}' ';'
+ bash ../src/ci/docker/host-x86_64/test-x86_64-fuchsia/build-fuchsia.sh
+ '[' -z '' ']'
+ curl --retry 10 -s 'https://fuchsia.googlesource.com/jiri/+/HEAD/scripts/bootstrap_jiri?format=TEXT'
+ base64 --decode
+ bash -s fuchsia
---
+ cd fuchsia
+ .jiri_root/bin/jiri init -partial-filter=tree:0 -analytics-opt=false .
+ .jiri_root/bin/jiri import -name=integration -revision=be532c365aa6ba56b08ed684c0f8bb71960c18fd -overwrite=true flower https://fuchsia.googlesource.com/integration
+ '[' -d .git ']'
+ .jiri_root/bin/jiri -j=10 update -autoupdate=false -attempts 10 -package-to-skip 'fuchsia/third_party/rust/host/${platform}' -package-to-skip fuchsia/third_party/rust/target/aarch64-apple-darwin -package-to-skip fuchsia/third_party/rust/target/aarch64-unknown-linux-gnu -package-to-skip fuchsia/third_party/rust/target/fuchsia -package-to-skip fuchsia/third_party/rust/target/riscv64gc-unknown-linux-gnu -package-to-skip fuchsia/third_party/rust/target/wasm32-unknown-unknown -package-to-skip fuchsia/third_party/rust/target/x86_64-apple-darwin -package-to-skip fuchsia/third_party/rust/target/x86_64-unknown-linux-gnu
[15:54:29.625] Updating all projects
[15:58:09.974] Fetching CIPD packages
[P54929 15:58:10.080 action_plan.go:259 I] Going to install 120 packages
[P54929 15:58:10.080 action_plan.go:178 I] In subdir "prebuilt/connectivity/bluetooth/bt-hci-virtual/arm64":
[P54929 15:58:10.080 action_plan.go:182 I]   to install:
---
[P54929 15:58:10.081 action_plan.go:184 I]     fuchsia/infra/zedmon/linux-amd64:8bOD87VKTLXbshNJ8LvFb_MC1lsEbobbv1f1bHhRA3gC
[P54929 15:58:10.081 action_plan.go:178 I] In subdir "prebuilt/virtualization/packages/aosp_gki":
[P54929 15:58:10.081 action_plan.go:182 I]   to install:
[P54929 15:58:10.081 action_plan.go:184 I]     fuchsia/third_party/aosp_gki/virt:kTGf9yslZgbbciD1PqQ9cRSLOx9hdpuWtcqam7Wx13QC
[P54929 15:58:10.083 instancecache.go:257 I] Using temporary instance cache at /checkout/obj/fuchsia/.cipd/tmp/dl_3826218342
[P54929 15:58:10.083 client.go:2104 I] [fetch   1/119] Resolving fetch URL for fuchsia/prebuilt/bt-hci-virtual/arm64:0v8c2B15yFtrz3VZCf9j0xxrCwRnrTLxfXnergt-lRQC
[P54929 15:58:10.175 storage.go:276 I] [fetch   1/119] Connecting...
[P54929 15:58:10.356 activities.go:174 I] [fetch   1/119] Fetching: 0.0/1.3 MB (  0%)
[P54929 15:58:10.468 client.go:2089 I] [fetch   1/119] Fetched fuchsia/prebuilt/bt-hci-virtual/arm64:0v8c2B15yFtrz3VZCf9j0xxrCwRnrTLxfXnergt-lRQC in 0.4s
[P54929 15:58:10.469 deployer.go:304 I] [unzip   1/119] Deploying fuchsia/prebuilt/bt-hci-virtual/arm64:0v8c2B15yFtrz3VZCf9j0xxrCwRnrTLxfXnergt-lRQC into /checkout/obj/fuchsia(/prebuilt/connectivity/bluetooth/bt-hci-virtual/arm64)
---
[P54929 15:58:47.521 deployer.go:407 I] [unzip 102/119] Cleaning up...
[P54929 15:58:47.522 deployer.go:413 I] [unzip 102/119] Deployed chromium/fuchsia/web_engine/arm64/tests:olbQ-sNFkZNCSDkY6ardUGwHqYD5pLwb80BSK662UxcC in 1.3s
[P54929 15:58:47.559 client.go:2408 I] All changes applied.
[15:58:47.638] WARN: Some packages are skipped by cipd due to lack of access, you might want to run "/checkout/obj/fuchsia/.jiri_root/bin/cipd auth-login" and try again
[15:58:49.254] Running package garbage collection in cache /checkout/obj/fuchsia/.jiri_root/packages with threshold 168h0m0s
[15:58:49.750] WARN: Empty hash file found at /checkout/obj/fuchsia/build/sdk/generate_prebuild_idk/validation_data/input_fuchsia_dir/prebuilt/fake_tool/x64/.jiri_cache_hash
++ git -C integration rev-parse HEAD
integration commit = be532c365aa6ba56b08ed684c0f8bb71960c18fd
+ echo integration commit = be532c365aa6ba56b08ed684c0f8bb71960c18fd
+ bash scripts/rust/build_fuchsia_from_rust_ci.sh
Metrics collection is already disabled.
---

+ echo
+ set +e
+ /checkout/obj/fuchsia/scripts/../.jiri_root/bin/fx clippy --all
ninja: Entering directory `/checkout/obj/fuchsia/out/workbench_eng.x64-balanced'
ninja: error: '/checkout/obj/install/lib/rustlib/src/rust/library/core/src/lib.rs', needed by 'kernel_x64.lk_debug_level_0/obj/zircon/kernel/lib/rust/libcore.rlib', missing and no known rule to make it

Clippy Diagnostics
==================

0 warning(s) emitted

Important

For more information how to resolve CI failures of this job, visit this link.

erickt · 2026-09-18T18:13:21Z

Could you also update this line from src to rust-src? https://github.com/rust-lang/rust/blob/main/src/ci/docker/host-x86_64/test-x86_64-fuchsia/install-rust-for-fuchsia.sh#L8

rustbot assigned Mark-Simulacrum Sep 7, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 7, 2026

This comment has been minimized.

Sign in to view

davidv1992 force-pushed the install-rust-src branch from 06fd35f to 39b6489 Compare September 7, 2026 14:04

This comment has been minimized.

Sign in to view

davidv1992 force-pushed the install-rust-src branch from 39b6489 to 348b669 Compare September 7, 2026 14:19

Mark-Simulacrum requested changes Sep 13, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2026

Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 14, 2026

rustbot mentioned this pull request Sep 14, 2026

Tracking issue for release notes of #162423: Rename the src install build step to rust-src. #162743

Open

davidv1992 force-pushed the install-rust-src branch from 348b669 to 0bf5f27 Compare September 16, 2026 07:43

rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 16, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2026

davidv1992 force-pushed the install-rust-src branch from 0bf5f27 to 0dc4b6b Compare September 16, 2026 08:00

jieyouxu reviewed Sep 16, 2026

View reviewed changes

Kobzol reviewed Sep 16, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 11 pull requests #162943

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 15 pull requests #162951

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 15 pull requests #162954

Closed

jieyouxu mentioned this pull request Sep 18, 2026

Temporarily disable test-x86_64-fuchsia #162972

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2026

This comment was marked as off-topic.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 18, 2026

Auto merge of #162423 - davidv1992:install-rust-src, r=<try>

de16a1c

Rename the src install build step to rust-src. try-job: test_x86_64-fuchsia

This comment was marked as off-topic.

Sign in to view

jieyouxu self-assigned this Sep 18, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 18, 2026

Auto merge of #162423 - davidv1992:install-rust-src, r=<try>

bc11f45

Rename the src install build step to rust-src. try-job: test-x86_64-fuchsia

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026

Uh oh!

Conversation

davidv1992 commented Sep 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 7, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidv1992 Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Sep 13, 2026

Uh oh!

rustbot commented Sep 13, 2026

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

davidv1992 commented Sep 16, 2026

Uh oh!

davidv1992 commented Sep 16, 2026

Uh oh!

jieyouxu commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidv1992 commented Sep 16, 2026

Uh oh!

jieyouxu Sep 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kobzol Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

jieyouxu commented Sep 18, 2026

Uh oh!

This comment was marked as off-topic.

This comment has been minimized.

This comment was marked as off-topic.

This comment was marked as off-topic.

jieyouxu commented Sep 18, 2026

Uh oh!

This comment has been minimized.

jieyouxu commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

rust-log-analyzer commented Sep 18, 2026

Uh oh!

erickt commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

davidv1992 commented Sep 7, 2026 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading

Mark-Simulacrum Sep 13, 2026 •

edited

Loading

jieyouxu commented Sep 16, 2026 •

edited

Loading

jieyouxu Sep 16, 2026 •

edited by rustbot

Loading