std: make a lot of items crate private by pacak · Pull Request #161612 · rust-lang/rust

pacak · 2026-08-23T17:37:36Z

Added #![warn(unreachable_pub)] in library/std/src/lib.rs
Added #[allow(unreachable_pub)] on top of std::os and std::sys specifically.

View all comments

r? clarfonthey

clarfonthey · 2026-08-23T19:32:29Z

So, looking at this, I'm going to nominate this for discussion alongside the clippy lints PR: #161328

Since they should go together, I think.

@rustbot label:I-libs-nominated

pacak · 2026-08-23T19:52:32Z

Sure.

Please no more obscure platform failures, please no more obscure platform failures, please no more obscure platform failures, please no more obscure platform failures...

Rollup of 5 pull requests Successful merges: - #162732 (Fix unsound dealloc of reborrows from custom allocators) - #154113 (std::net: clamp multicast ttl value to u8 max.) - #161178 (lint ineffective #[unstable] annotations on re-exports) - #161612 (std: make a lot of items crate private) - #162717 (prevent ICE from `derive` on `repr(packed)` enum)

jhpratt · 2026-09-14T01:02:32Z

Looks like there are two things: one case was missed and the lint was left enabled in some spot (despite the PR description).

#162737 (comment)

@bors r-

rust-bors · 2026-09-14T01:02:39Z

This pull request was unapproved.

This PR was contained in a rollup (#162737), which was unapproved.

View changes since this unapproval

rustbot · 2026-09-14T07:43:21Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Most of them don't need to be public, but there are scenarios where thing is private on one platform but public on the other, so having a lint on all the time gets complicated. Added #![warn(unreachable_pub)] in library/std/src/lib.rs Added #[allow(unreachable_pub)] on top of std::os and std::sys specifically.

pacak · 2026-09-14T07:50:29Z

Updated the description, reduced visibility in two missing cases in library/std/src/process/tests.rs.

clarfonthey · 2026-09-14T23:40:52Z

@bors retry

rust-bors · 2026-09-14T23:40:55Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

Hint: If you wanted to retry pull request CI instead, push the latest commit again, or close and then reopen this PR.

clarfonthey · 2026-09-14T23:41:20Z

@bors r+ rollup

rust-bors · 2026-09-14T23:41:23Z

📌 Commit 0f916bb has been approved by clarfonthey

It is now in the queue for this repository.

std: make a lot of items crate private 1. Added `#![warn(unreachable_pub)]` in `library/std/src/lib.rs` 2. Added `#[allow(unreachable_pub)]` on top of `std::os` and `std::sys` specifically. r? clarfonthey

Rollup of 7 pull requests Successful merges: - #160911 (Remove d32 feature from 32-bit Arm targets) - #162771 (Filter do_not_recommend impls before handling a single candidate) - #162779 (rustdoc: Revert "fix bare urls split text") - #161612 (std: make a lot of items crate private) - #162372 (Clean up `test/rustdoc-html` folder by moving tests where appropriate) - #162643 (Fix `path_trailing_sep` methods for Windows verbatim paths) - #162784 (AGENTS.md: Permit local experimentation, per the online policy.)

std: make a lot of items crate private 1. Added `#![warn(unreachable_pub)]` in `library/std/src/lib.rs` 2. Added `#[allow(unreachable_pub)]` on top of `std::os` and `std::sys` specifically. r? clarfonthey

Rollup of 10 pull requests Successful merges: - #160911 (Remove d32 feature from 32-bit Arm targets) - #162771 (Filter do_not_recommend impls before handling a single candidate) - #162779 (rustdoc: Revert "fix bare urls split text") - #161548 (hir_typeck: Don't ICE on closures without drop location in closure capture lint) - #161612 (std: make a lot of items crate private) - #162204 (Suggest keyword order for `extern "C" const unsafe fn`) - #162372 (Clean up `test/rustdoc-html` folder by moving tests where appropriate) - #162638 (dont suggest changing the mutability of a borrow that comes from a macro) - #162643 (Fix `path_trailing_sep` methods for Windows verbatim paths) - #162784 (AGENTS.md: Permit local experimentation, per the online policy.)

…uwer Rollup of 12 pull requests Successful merges: - #160911 (Remove d32 feature from 32-bit Arm targets) - #161868 (libtest: never iterate over all tests in `--exact` mode) - #162771 (Filter do_not_recommend impls before handling a single candidate) - #162779 (rustdoc: Revert "fix bare urls split text") - #161548 (hir_typeck: Don't ICE on closures without drop location in closure capture lint) - #161612 (std: make a lot of items crate private) - #162204 (Suggest keyword order for `extern "C" const unsafe fn`) - #162372 (Clean up `test/rustdoc-html` folder by moving tests where appropriate) - #162638 (dont suggest changing the mutability of a borrow that comes from a macro) - #162643 (Fix `path_trailing_sep` methods for Windows verbatim paths) - #162654 (Improve Armv7-R documentation) - #162784 (AGENTS.md: Permit local experimentation, per the online policy.)

Rollup merge of #161612 - pacak:unreachable-pub, r=clarfonthey std: make a lot of items crate private 1. Added `#![warn(unreachable_pub)]` in `library/std/src/lib.rs` 2. Added `#[allow(unreachable_pub)]` on top of `std::os` and `std::sys` specifically. r? clarfonthey

rustbot added the O-unix Operating system: Unix-like label Aug 23, 2026

rustbot assigned clarfonthey Aug 23, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 23, 2026