Rollup of 4 pull requests#159757
Closed
jhpratt wants to merge 12 commits into
Closed
Conversation
…d ZST struct/enums. Also add tests for the guaranteed types.
… r=davidtwco Update comments and add tests for `-Zrandomize-layout` for some guaranteed ZSTs See rust-lang/reference#2262 . T-lang wants to make some additional guarantees about zero-sized `repr(Rust)` structs and enums, that changes to `-Zrandomize-layout` could theoretically break in the future. This PR adds comments to `-Zrandomize-layout`'s implementation and tests to `tests/ui/layout/randomize.rs` to prevent breaking those guarantees. First commit is the guarantees that T-lang already FCP'd in rust-lang/reference#2262 . Second commit is an additional guarantee (that zero-variant repr(Rust) enums are ZSTs) that's at rust-lang/reference#2293 (FCP now completed)
…=davidtwco doc: document wasm import symbol mangling Document that foreign items from wasm_import_module extern blocks are mangled even with #[no_mangle] or #[link_name], so same-named imports from different WebAssembly modules remain distinct.
…dtwco early_otherwise: Don't hoist dereferences when the otherwise branch is reachable Fixes rust-lang#159591. A place may contain a dereference that cannot be safely hoisted when the otherwise branch is reachable.
…=davidtwco run `tests/assembly-llvm/asm/aarch64-types.rs` for `aarch64_be` We may as well, tangentially related to rust-lang#154342. r? davidtwco
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Zrandomize-layoutfor some guaranteed ZSTs #157905 (Update comments and add tests for-Zrandomize-layoutfor some guaranteed ZSTs)tests/assembly-llvm/asm/aarch64-types.rsforaarch64_be#159653 (runtests/assembly-llvm/asm/aarch64-types.rsforaarch64_be)r? @ghost
Create a similar rollup