Rollup of 8 pull requests#159748
Conversation
recv_inner returned the datagram length instead of the bytes copied into the caller's buffer, and rxlen >= 4075 could index past the receive buffer and panic. Clamp the count to both buffers, mirroring the earlier send_to fix.
Signed-off-by: wanglei <wllenyj@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
…,Nadrieril Abort const-eval queries early when there are generics in the type Since [recently](rust-lang#156977), const validation has a `has_param` check, which means ConstToPat also implicitly has that check. But it seems better to check this again explicitly here rather then rely on an undocumented property of some other component. The new test behaves the same with or without the PR. I recommend hiding whitespace difference, since rustfmt re-indendet a bunch of stuff. Fixes rust-lang#150296 r? @BoxyUwU
std: fix Xous UDP recv length over-report and OOB panic recv_inner returned the datagram length instead of the bytes copied into the caller's buffer, and rxlen >= 4075 could index past the receive buffer and panic. Clamp the count to both buffers, as in rust-lang#158928.
Add fallback for `intrinsics::fabs` Add a fallback for the `fabs` intrinsic. Because it uses const traits and const ops it required adding `rustc_const_unstable` -- i'm not certain it's right but it seems to make sense. I also added `#[miri::intrinsic_fallback_is_spec]`, though im not sure if I need to modify the const eval code to remove `fabs` handling or to remove it from any of the backends r? folkertdev
bump std libc to 0.2.189 Upgrade the std libc version to the latest `v0.2.189` from `v0.2.185`. There are too many changes between `v0.2.186` and `v0.2.187`, I'm not sure if `libc`'s update strategy is one version at a time, or if it allows upgrading multiple versions at once. I now need to resolve the CI failure caused by `libc::SO_KEEPALIVE` in the `socket2` crate for rust-lang/socket2#666 ``` hide running `cargo check -Z build-std=std,panic_abort --target thumbv8m.main-nuttx-eabihf --no-default-features` on socket2 (1/2) Updating crates.io index Locking 3 packages to latest compatible versions Downloading crates ... Downloaded libc v0.2.189 Updating crates.io index Downloading crates ... Downloaded addr2line v0.27.0 Downloaded foldhash v0.2.0 Downloaded getopts v0.2.24 Downloaded cfg-if v1.0.4 Downloaded memchr v2.7.6 Downloaded rustc-literal-escaper v0.0.8 Downloaded object v0.39.1 Downloaded rustc-demangle v0.1.28 Downloaded libc v0.2.185 Downloaded adler2 v2.0.1 Downloaded gimli v0.34.0 Downloaded hashbrown v0.17.1 Downloaded miniz_oxide v0.9.1 Compiling compiler_builtins v0.1.160 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/compiler-builtins/compiler-builtins) Compiling core v0.0.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core) Compiling libc v0.2.185 Compiling object v0.39.1 Compiling std v0.0.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std) Compiling libc v0.2.189 Compiling rustc-std-workspace-core v1.99.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core) Compiling alloc v0.0.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc) Compiling adler2 v2.0.1 Compiling memchr v2.7.6 Compiling unwind v0.0.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/unwind) Compiling cfg-if v1.0.4 Compiling rustc-demangle v0.1.28 Compiling panic_abort v0.0.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/panic_abort) Compiling rustc-literal-escaper v0.0.8 Compiling rustc-std-workspace-alloc v1.99.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-alloc) Compiling panic_unwind v0.0.0 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/panic_unwind) Compiling gimli v0.34.0 Compiling hashbrown v0.17.1 Compiling miniz_oxide v0.9.1 Compiling std_detect v0.1.5 (/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std_detect) Compiling addr2line v0.27.0 error[E0425]: cannot find value `SO_KEEPALIVE` in crate `libc` --> /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/net/connection/socket/unix.rs:462:59 | 462 | unsafe { setsockopt(self, libc::SOL_SOCKET, libc::SO_KEEPALIVE, keepalive as c_int) } | ^^^^^^^^^^^^ not found in `libc` error[E0425]: cannot find value `SO_KEEPALIVE` in crate `libc` --> /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/net/connection/socket/unix.rs:466:76 | 466 | let raw: c_int = unsafe { getsockopt(self, libc::SOL_SOCKET, libc::SO_KEEPALIVE)? }; | ^^^^^^^^^^^^ not found in `libc` ```
…-variant, r=lqd Add new variant to iterating-updating-mutref borrowck test This is a useful variant to consider when porting to a-mir-formality. r? lqd
fs::hard_link: use linkat on Android According to rust-lang@6249cda, `linkat` needs API level 21. That is ancient (2014, Android 5). Our [target page](https://doc.rust-lang.org/rustc/platform-support/android.html) does not say which minimum Android version or API level we support, it just says: > Rust will support the most recent Long Term Support (LTS) Android Native Development Kit (NDK). By default Rust will support all API levels supported by the NDK, but a higher minimum API level may be required if deemed necessary. That's pretty useless as I have no idea how I'd figure out what the "API levels support by the NDK" are. Cc @chriswailes @jfgoog @maurer @pirama-arumuga-nainar Fixes rust-lang/miri#5080
…e1-dead Consider `()` as suspicious only when expecting `!` for runtime symbols Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (rust-lang#159446 (comment)). Fixes rust-lang#159446
…te, r=GuillaumeGomez Document the link_section attribute Part of rust-lang#157604 r? @GuillaumeGomez
This comment has been minimized.
This comment has been minimized.
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: e7795af6d2 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e7795af (parent) -> 390279b (this PR) Test differencesShow 25 test diffsStage 1
Stage 2
Additionally, 22 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 390279b302ca98ae270f434100ae3730531d1246 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (390279b): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%, secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.2%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 486.654s -> 486.724s (0.01%) |
Successful merges:
intrinsics::fabs#159605 (Add fallback forintrinsics::fabs)()as suspicious only when expecting!for runtime symbols #159513 (Consider()as suspicious only when expecting!for runtime symbols)r? @ghost
Create a similar rollup