implement CovariantUnsafeCell#159738
Open
WaffleLapkin wants to merge 2 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
WaffleLapkin
commented
Jul 22, 2026
| #[rustc_should_not_be_called_on_const_items] | ||
| #[unstable(feature = "covariant_unsafe_cell", issue = "159735")] | ||
| #[rustc_const_unstable(feature = "covariant_unsafe_cell", issue = "159735")] | ||
| pub const fn get(&self) -> NonNull<T> { |
Member
Author
There was a problem hiding this comment.
Minor divergence from the ACP: returning NonNull<T> instead of *mut T.
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
covariant-unsafe-cell
branch
2 times, most recently
from
July 22, 2026 19:53
b2a7ea2 to
c37239a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #159735 / rust-lang/libs-team#815.