Stabilize passing 128-bit integers via vector registers with asm! on x86#159525
Open
folkertdev wants to merge 2 commits into
Open
Stabilize passing 128-bit integers via vector registers with asm! on x86#159525folkertdev wants to merge 2 commits into
asm! on x86#159525folkertdev wants to merge 2 commits into
Conversation
2 tasks
Contributor
|
Thanks @folkertdev. @rfcbot fcp merge lang |
Collaborator
|
@traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
Member
|
@rfcbot reviewed |
1 similar comment
Contributor
|
@rfcbot reviewed |
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Amanieu
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #133416
reference PR: rust-lang/reference#2313
Stabilization report
Summary
Stabilize passing 128-bit integers via vector registers with
asm!on x86 and x86_64:32-bit and 64-bit integer types can already be passed via vector registers. LLVM has supported 128-bit integers since 2019, see llvm/llvm-project#42502, so
rustcnot supporting them seems like an oversight.This feature is part of
asm_experimental_reg. We're not stabilizing that feature as a whole, but only pull out part of it.History
u128/i128to inline assembly #151059Open questions
None.
r? Amanieu