Skip to content

[compiletest] Differentiate between LLVM LLDB and Apple LLDB#159215

Open
Walnut356 wants to merge 1 commit into
rust-lang:mainfrom
Walnut356:lldb_vers
Open

[compiletest] Differentiate between LLVM LLDB and Apple LLDB#159215
Walnut356 wants to merge 1 commit into
rust-lang:mainfrom
Walnut356:lldb_vers

Conversation

@Walnut356

@Walnut356 Walnut356 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This patch causes compiletest to treat LLVM and Apple LLDB versions uniquely, including modified min-version directives. We'll need this level of granularity going forward:

Any tests that specified min-lldb-version have been updated to equivalent min-apple-lldb-version and min-llvm-lldb-version directives to preserve existing test filters.

r? @Kobzol, @jieyouxu

@rustbot

rustbot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2026
@rustbot

rustbot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasoanble, one question

View changes since this review

Comment thread src/tools/compiletest/src/debuggers.rs
@rust-log-analyzer

This comment has been minimized.

@Kobzol

Kobzol commented Jul 13, 2026

Copy link
Copy Markdown
Member

Later we can add some small command to auto-bump those versions across all debugger files, lol. Though Find + replace will also do, I guess.

Thanks, this looks like it should unblock checking for LLDB on CI.

@jieyouxu jieyouxu closed this Jul 15, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2026
@jieyouxu jieyouxu reopened this Jul 15, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2026
@rust-bors

This comment has been minimized.

Comment thread src/tools/compiletest/src/debuggers.rs Outdated
@rustbot

rustbot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants