Add io::ErrorKind::InputOutputError#159070
Open
valentynkit wants to merge 1 commit into
Open
Conversation
`EIO` decoded to `ErrorKind::Uncategorized`, so a low-level I/O failure could only be detected through `raw_os_error()`. Map it, and the equivalent codes on Windows (`ERROR_IO_DEVICE`) and VEXos (`FR_DISK_ERR`), to a new unstable `InputOutputError` variant.
rustbot
added
S-waiting-on-review
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an unstable
io::ErrorKind::InputOutputErrorfor low-level I/O failures.EIOcurrently decodes toErrorKind::Uncategorized, so stable code cannot tell that an operation failed at the low-level I/O layer without inspectingraw_os_error()and a platform-specificlibc/windows-sysconstant.Implements the accepted ACP rust-lang/libs-team#824. The variant name is still open for bikeshedding before stabilization (see the ACP); this uses
InputOutputErroras accepted for now.The variant maps:
EIOon Unix, WASI, and teeosERROR_IO_DEVICEon WindowsFR_DISK_ERRon VEXosI didn't add a test, since the decode tables don't have one today (same as #158326).
Tracking issue: #159066
r? libs