Reapply "LLVM 23: Run AssignGUIDPass in some places" by durin42 · Pull Request #158961 · rust-lang/rust

durin42 · 2026-07-08T16:04:01Z

This reverts commit 4919940.

This is a re-do of #157055 now that the corresponding LLVM change has re-landed.

rustbot · 2026-07-08T16:04:04Z

Some changes occurred in tests/codegen-llvm/sanitizer

rustbot · 2026-07-08T16:04:07Z

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

durin42 · 2026-07-08T16:04:23Z

@rustbot label llvm-main

This reverts commit 4919940.

Urgau · 2026-07-08T16:29:46Z

Would you mind posting the LLVM PR that re-landed it?

durin42 · 2026-07-08T16:35:51Z

llvm/llvm-project#201849 is the reland

nikic · 2026-07-09T09:31:06Z

@bors r+ rollup

rust-bors · 2026-07-09T09:31:09Z

📌 Commit b8d3a4a has been approved by nikic

It is now in the queue for this repository.

…=nikic Reapply "LLVM 23: Run AssignGUIDPass in some places" This reverts commit 4919940. This is a re-do of rust-lang#157055 now that the corresponding LLVM change has re-landed.

…uwer Rollup of 17 pull requests Successful merges: - #158510 (Enable `static_position_independent_executables` on all gnu and musl targets) - #158541 (Move `std::io::Write` to `core::io`) - #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`) - #155429 (Support `u128`/`i128` c-variadic arguments) - #156370 (Reject linked dylib EII default overrides) - #157153 (allow `Allocator`s to be used as `#[global_allocator]`s) - #158535 (Support `#[track_caller]` on EII declarations) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158988 (Redo `TokenStreamIter`) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158739 (view-types: HIR lowering) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158886 (Add documentation for the `no_std` attribute) - #158951 (Merge three `MaxUniverse`s into one) - #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places")

…=nikic Reapply "LLVM 23: Run AssignGUIDPass in some places" This reverts commit 4919940. This is a re-do of rust-lang#157055 now that the corresponding LLVM change has re-landed.

…uwer Rollup of 21 pull requests Successful merges: - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158510 (Enable `static_position_independent_executables` on all gnu and musl targets) - #158541 (Move `std::io::Write` to `core::io`) - #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`) - #155429 (Support `u128`/`i128` c-variadic arguments) - #156370 (Reject linked dylib EII default overrides) - #156508 (Infer all anonymous lifetimes in assoc consts as `'static`) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158859 (Improve `-Zls` diagnostic message on `.rs` files) - #158988 (Redo `TokenStreamIter`) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158739 (view-types: HIR lowering) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158886 (Add documentation for the `no_std` attribute) - #158940 (Implement feature `char_to_u32`) - #158951 (Merge three `MaxUniverse`s into one) - #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places") - #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes) - #159005 (Use `as_lang_item` instead of repeatedly matching)

…=nikic Reapply "LLVM 23: Run AssignGUIDPass in some places" This reverts commit 4919940. This is a re-do of rust-lang#157055 now that the corresponding LLVM change has re-landed.

…uwer Rollup of 24 pull requests Successful merges: - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158510 (Enable `static_position_independent_executables` on all gnu and musl targets) - #158541 (Move `std::io::Write` to `core::io`) - #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`) - #156027 (Consider captured regions for opaque type region liveness.) - #156370 (Reject linked dylib EII default overrides) - #156508 (Infer all anonymous lifetimes in assoc consts as `'static`) - #157561 (rustdoc: do not include extra stuff in span) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158859 (Improve `-Zls` diagnostic message on `.rs` files) - #158988 (Redo `TokenStreamIter`) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158384 (Allow BackwardIncompatibleDropHint in polonius legacy) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158739 (view-types: HIR lowering) - #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158886 (Add documentation for the `no_std` attribute) - #158940 (Implement feature `char_to_u32`) - #158951 (Merge three `MaxUniverse`s into one) - #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places") - #158995 (Use REST API in linkchecker script) - #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)

…=nikic Reapply "LLVM 23: Run AssignGUIDPass in some places" This reverts commit 4919940. This is a re-do of rust-lang#157055 now that the corresponding LLVM change has re-landed.

Rollup of 24 pull requests Successful merges: - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158541 (Move `std::io::Write` to `core::io`) - #156027 (Consider captured regions for opaque type region liveness.) - #156370 (Reject linked dylib EII default overrides) - #156508 (Infer all anonymous lifetimes in assoc consts as `'static`) - #157561 (rustdoc: do not include extra stuff in span) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158859 (Improve `-Zls` diagnostic message on `.rs` files) - #158988 (Redo `TokenStreamIter`) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158384 (Allow BackwardIncompatibleDropHint in polonius legacy) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158739 (view-types: HIR lowering) - #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158886 (Add documentation for the `no_std` attribute) - #158940 (Implement feature `char_to_u32`) - #158951 (Merge three `MaxUniverse`s into one) - #158960 (Fix bootstrap submodule path prefix matching) - #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places") - #158995 (Use REST API in linkchecker script) - #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes) - #159036 (bootstrap: expand '@argfile' arguments to rustc shim)

Rollup merge of #158961 - durin42:llvm-23-guid-pass-again, r=nikic Reapply "LLVM 23: Run AssignGUIDPass in some places" This reverts commit 4919940. This is a re-do of #157055 now that the corresponding LLVM change has re-landed.

JonathanBrouwer · 2026-07-12T07:42:15Z

@rust-timer build 3f5d238

rust-timer · 2026-07-12T13:01:03Z

Finished benchmarking commit (3f5d238): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.1%	[0.0%, 0.3%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	3
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results (primary -1.1%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-3.3%, -2.2%]	2
Improvements ✅ (secondary)	-1.8%	[-3.1%, -1.1%]	3
All ❌✅ (primary)	-1.1%	[-3.3%, 2.2%]	3

Cycles

Results (secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[2.2%, 8.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-8.9%, -1.7%]	8
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.768s -> 492.214s (0.29%)
Artifact size: 389.74 MiB -> 389.00 MiB (-0.19%)

rustbot assigned mejrs Jul 8, 2026

rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Jul 8, 2026

This comment has been minimized.

Sign in to view

Reapply "LLVM 23: Run AssignGUIDPass in some places"

b8d3a4a

This reverts commit 4919940.

durin42 force-pushed the llvm-23-guid-pass-again branch from 60d7b50 to b8d3a4a Compare July 8, 2026 16:17

zmodem mentioned this pull request Jul 8, 2026

Reland "LLVM 23: Run AssignGUIDPass in some places" #158964

Closed

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2026

JonathanBrouwer mentioned this pull request Jul 9, 2026

Rollup of 17 pull requests #159007

Closed

JonathanBrouwer mentioned this pull request Jul 9, 2026

Rollup of 18 pull requests #159013

Closed

JonathanBrouwer mentioned this pull request Jul 9, 2026

Rollup of 21 pull requests #159020

Closed

JonathanBrouwer mentioned this pull request Jul 9, 2026

Rollup of 21 pull requests #159024

Closed

JonathanBrouwer mentioned this pull request Jul 9, 2026

Rollup of 24 pull requests #159037

Closed

This was referenced Jul 9, 2026

Rollup of 25 pull requests #159045

Closed

Rollup of 24 pull requests #159046

Merged

rust-bors Bot merged commit d2426f6 into rust-lang:main Jul 10, 2026
15 of 26 checks passed

rustbot added this to the 1.99.0 milestone Jul 10, 2026

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jul 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Reapply "LLVM 23: Run AssignGUIDPass in some places"#158961

Reapply "LLVM 23: Run AssignGUIDPass in some places"#158961
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-guid-pass-again

durin42 commented Jul 8, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jul 8, 2026

Uh oh!

rustbot commented Jul 8, 2026

Uh oh!

durin42 commented Jul 8, 2026

Uh oh!

This comment has been minimized.

Urgau commented Jul 8, 2026

Uh oh!

durin42 commented Jul 8, 2026

Uh oh!

nikic commented Jul 9, 2026

Uh oh!

rust-bors Bot commented Jul 9, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

durin42 commented Jul 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 8, 2026

Uh oh!

rustbot commented Jul 8, 2026

Uh oh!

durin42 commented Jul 8, 2026

Uh oh!

This comment has been minimized.

Urgau commented Jul 8, 2026

Uh oh!

durin42 commented Jul 8, 2026

Uh oh!

nikic commented Jul 9, 2026

Uh oh!

rust-bors Bot commented Jul 9, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 12, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

durin42 commented Jul 8, 2026 •

edited by rustbot

Loading