Some ast lowering partial-res cleanups#158948
Open
oli-obk wants to merge 4 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
petrochenkov
reviewed
Jul 9, 2026
| } | ||
|
|
||
| fn get_full_res(&self, id: NodeId) -> Option<Res<NodeId>> { | ||
| self.get_partial_res(id)?.full_res() |
Contributor
There was a problem hiding this comment.
The behavior here is different from expect_full_res.
get_partial_res can return None in two cases:
iddoes not refer to any kind of path, we'd ideally panic in this case, this should not happen.idrefers to some unsuccessfully resolved path, we do not always putRes::Errfor such paths into the table, unfortunately.
That's whyfn expect_full_resdefaults toRes::Errif it doesn't find anything in the table. That is better than what this function does, becauseRes::Erris a full resolution. But it is also fishy because it createsRes::ErrwithoutErrorGuaranteed, ideally we'd rundelayed_bugif that fallback happens.
petrochenkov
added
S-waiting-on-author
Contributor
|
☔ The latest upstream changes (presumably #159057) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everyone (including me) pretty much randomly uses whatever works between
get_partial_res,expect_partial_resandexpect_full_res. I went through all use sites and picked the strictest one, and added some helpers along the line. Also added docs guiding ppl towards the stricter onesr? @cjgillot or @petrochenkov