Skip to content

cleanup: upstream dropped AMX-TF32#158910

Open
krasimirgg wants to merge 1 commit into
rust-lang:mainfrom
krasimirgg:jul26-llvm-amx
Open

cleanup: upstream dropped AMX-TF32#158910
krasimirgg wants to merge 1 commit into
rust-lang:mainfrom
krasimirgg:jul26-llvm-amx

Conversation

@krasimirgg

Copy link
Copy Markdown
Contributor

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a cleanup similar to #148338.

@rustbot label llvm-main
r? @durin42

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Jul 7, 2026
@rust-log-analyzer

This comment has been minimized.

@krasimirgg krasimirgg marked this pull request as ready for review July 7, 2026 14:32
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2026
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Some changes occurred in std_detect

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 7, 2026
@rust-log-analyzer

This comment has been minimized.

@workingjubilee

Copy link
Copy Markdown
Member

Can you add a

//@ normalize-stderr:

line at the top of the relevant test which fixes up the "and XX more" from a number like 75 or whatever that constantly gets diffed into a normalized value? It should leave the rest of the test output unchanged, in particular it has to suggest the same features first.

@folkertdev

Copy link
Copy Markdown
Contributor

Could you make the changes in library/stdarch/crates/core_arch/* as a separate PR over at rust-lang/stdarch? As written this PR will break stdarch CI. We'll sync changes back over to here once merged over there.

@durin42

durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Can you add a

//@ normalize-stderr:

line at the top of the relevant test which fixes up the "and XX more" from a number like 75 or whatever that constantly gets diffed into a normalized value? It should leave the rest of the test output unchanged, in particular it has to suggest the same features first.

That's already mailed as #158922 - probably that will land faster than this.

@krasimirgg

Copy link
Copy Markdown
Contributor Author

Could you make the changes in library/stdarch/crates/core_arch/* as a separate PR over at rust-lang/stdarch? As written this PR will break stdarch CI. We'll sync changes back over to here once merged over there.

Prepped rust-lang/stdarch#2184.

@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2026
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jul 9, 2026
@folkertdev

Copy link
Copy Markdown
Contributor

This is blocked on the sync actually being merged #158968

@rust-log-analyzer

This comment has been minimized.

@nikic

nikic commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 20a9498 has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 9, 2026
cleanup: upstream dropped AMX-TF32

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a cleanup similar to rust-lang#148338.

@rustbot label llvm-main
r? @durin42
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #159020 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2026
@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#159020), which was unapproved.

View changes since this unapproval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants