Promote riscv64-unknown-linux-musl to tier 2 with host tools by eshattow · Pull Request #158766 · rust-lang/rust

eshattow · 2026-07-04T07:21:31Z

View all comments

MCP: rust-lang/compiler-team#982

Implements #156191

rustbot · 2026-07-04T07:21:36Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

rustbot · 2026-07-04T07:21:39Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @marcoieni (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: infra-ci
infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

marcoieni · 2026-07-07T09:55:21Z

@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu

Promote riscv64-unknown-linux-musl to tier 2 with host tools try-job: dist-riscv64-linux-musl try-job: dist-riscv64-linux-gnu

marcoieni · 2026-07-07T10:07:22Z

Maybe the failure is due to this codex finding, which I copy-paste without editing:

[P1] New Docker image does not copy the crosstool-ng checksum patch.
Dockerfile:6 runs crosstool-ng.sh, but that script unconditionally reads /scripts/crosstool-ng-sha256-20260705.diff at crosstool-ng.sh:20. The existing RISC-V GNU image copies that file before running the script.

rust-bors · 2026-07-07T12:00:06Z

💔 Test for 9d14c25 failed: CI. Failed job:

try - dist-riscv64-linux-musl (web logs, enhanced plaintext logs)

eshattow · 2026-07-07T14:18:52Z

@marcoieni writes:

Maybe the failure is due to this codex finding, which I copy-paste without editing:
...

I'd missed this, as it is a recent change to resolve the fallout of kernel.org mirrors CDN being down for several days.

Added the appropriate COPY line to the Dockerfile and pushed, thanks for the suggestion :-)

marcoieni · 2026-07-23T08:06:16Z

Also is there any requirement to add myself as a code maintainer?

You mean as a target maintainer? Or you want to join some Rust teams? I would ask in zulip in a new topic in #t-infra 👍

there is some missing address sanitizer coverage of both -gnu and -musl targets that would be appropriate for a follow-up issue but is not any blocker here now.

should we create an issue so we don't forget about it?

Thanks for your assistance

No worries, thank you for the contribution! This PR is good to go imo. I will approve it after the bors try succeeds!

I want to know any obvious problems with documentation changes or omissions.

I got this from GPT 5.6 but I'm not sure if it makes sense:

Cross-compilation instructions omit the required linker.
riscv64gc-unknown-linux-musl.md (line 42) implies that installing the Rust target is enough. Executables still invoke cc by default, which cannot link RISC-V objects on another host. Document a RISC-V musl toolchain and a .cargo/config.toml entry using riscv64-unknown-linux-musl-gcc.

Feel free to address it here, in another PR or never 😅

rust-bors · 2026-07-23T09:59:48Z

☀️ Try build successful (CI)
Build commit: e2fbfe0 (e2fbfe0d2ad5f5865db3cfedd186be2f5eac5cfb)
Base parent: 390279b (390279b302ca98ae270f434100ae3730531d1246)

marcoieni · 2026-07-23T10:37:24Z

@bors r+ rollup=always

rust-bors · 2026-07-23T10:37:27Z

📌 Commit 2af4af2 has been approved by marcoieni

It is now in the queue for this repository.

marcoieni · 2026-07-23T10:38:03Z

The job duration is also good btw

…marcoieni Promote riscv64-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#982 Implements rust-lang#156191

Rollup of 19 pull requests Successful merges: - #150161 (Remove 'static requirement on try_as_dyn) - #158362 (trait solver: account for universes from replace_bound_vars) - #159173 (Add allowed list check on EII implementations attributes) - #159466 (cmse: clear variant-dependent padding in `enum`s) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #157905 (Update comments and add tests for `-Zrandomize-layout` for some guaranteed ZSTs) - #158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - #159041 (Reorganize `tests/ui/issues` [22/N]) - #159108 (Reorganize `tests/ui/issues` [23/N]) - #159138 (doc: document wasm import symbol mangling) - #159531 (Reorganize `tests/ui/issues` [28/N]) - #159608 (early_otherwise: Don't hoist dereferences when the otherwise branch is reachable) - #159612 (Reorganize `tests/ui/issues` [29/N]) - #159653 (run `tests/assembly-llvm/asm/aarch64-types.rs` for `aarch64_be`) - #159667 (Make some parser structured suggestions verbose and tweak their wording) - #159759 (rustc-dev-guide subtree update) - #159761 (Remove outdated comment for resolve_vars_with_obligations)

…marcoieni Promote riscv64-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#982 Implements rust-lang#156191

jhpratt · 2026-07-23T22:30:25Z

Trying to figure out the cause of #159793

@bors try jobs=dist-various-1

Promote riscv64-unknown-linux-musl to tier 2 with host tools try-job: dist-various-1

rust-bors · 2026-07-24T00:04:28Z

☀️ Try build successful (CI)
Build commit: 6bfb0fe (6bfb0fe0b7ccdf37506a506066b1d27176084222)
Base parent: 2d8fa67 (2d8fa67781953811835f7ae45f670afbb7f44285)

…marcoieni Promote riscv64-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#982 Implements rust-lang#156191

Rollup of 12 pull requests Successful merges: - #159765 (Avoid spurious rebuilds of JSON docs in bootstrap) - #159781 (Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata) - #158362 (trait solver: account for universes from replace_bound_vars) - #159173 (Add allowed list check on EII implementations attributes) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #159722 ( [rustdoc] Retrieve `cfg_attr` information for derived impls for `doc_cfg` feature) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - #159271 (str: add ASCII fast path to word_to_titlecase) - #159666 (fix(ld64.lld): route version mismatch warnings to linker_info on macOS) - #159667 (Make some parser structured suggestions verbose and tweak their wording)

Rollup of 14 pull requests Successful merges: - #159765 (Avoid spurious rebuilds of JSON docs in bootstrap) - #159781 (Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata) - #158362 (trait solver: account for universes from replace_bound_vars) - #158372 (rustfmt: Discover modules via `cfg_select!`) - #159173 (Add allowed list check on EII implementations attributes) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #159722 ( [rustdoc] Retrieve `cfg_attr` information for derived impls for `doc_cfg` feature) - #159731 (std: Implement futex on wasip3 targets, update target spec) - #159755 (Improve consistency of attribute error messages) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - #159271 (str: add ASCII fast path to word_to_titlecase) - #159667 (Make some parser structured suggestions verbose and tweak their wording)

Rollup merge of #158766 - eshattow:linux-musl-riscv64-ci, r=marcoieni Promote riscv64-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#982 Implements #156191

rustbot assigned marcoieni Jul 4, 2026