Move std::io::buffered to alloc::io#158547
Open
bushrat011899 wants to merge 16 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
T-libs
Contributor
Author
|
@rustbot blocked |
rustbot
added
S-blocked
This was referenced Jun 29, 2026
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
from
999bae7 to
ed009e7
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
2 times, most recently
from
dd63a8f to
bc8b452
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
from
bc8b452 to
62c2a52
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
from
62c2a52 to
29b77fb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
from
29b77fb to
a70a3c2
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
from
a70a3c2 to
f266f4c
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
Moves unsafe code from `alloc::io` into `alloc::vec`. A more general `try_extend_from_slice` may be useful in the future, but that requires changing how specialization is done for `SpecExtend` and that's a lot for an internal-only function.
None of the currently public methods are accessible outside `std`, and are unused within. Therefore, they can be restricted to internal use.
bushrat011899
force-pushed
the
alloc_io_buffered
branch
from
f266f4c to
e5311db
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158546
Description
Moves
std::io::BufReader/BufWriter/LineWriter/etc. toalloc::io. This is effectively a direct cut and paste. Blocked on #158546.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.