Skip to content

Allow BackwardIncompatibleDropHint in polonius legacy#158384

Open
KiChjang wants to merge 1 commit into
rust-lang:mainfrom
KiChjang:allow-backward-incompat-drop-hint
Open

Allow BackwardIncompatibleDropHint in polonius legacy#158384
KiChjang wants to merge 1 commit into
rust-lang:mainfrom
KiChjang:allow-backward-incompat-drop-hint

Conversation

@KiChjang

@KiChjang KiChjang commented Jun 25, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #157568.

Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2026
@rustbot

rustbot commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates

@KiChjang

KiChjang commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

r? @lqd

@rustbot rustbot assigned lqd and unassigned folkertdev Jun 25, 2026
@KiChjang

KiChjang commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

This is actually a small enough PR that anyone can just review, so r? @folkertdev

@rustbot rustbot assigned folkertdev and unassigned lqd Jul 8, 2026
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

Isn't this hint only used when migrating to edition2024? Why do you want to do this?

Especially since we're planning on removing the legacy implementation in due time.

@KiChjang

KiChjang commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.

lqd
lqd reviewed Jul 8, 2026
View reviewed changes
Comment thread tests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs
@folkertdev

folkertdev commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

r? lqd

@rustbot rustbot assigned lqd and unassigned folkertdev Jul 8, 2026
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

r? me

It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).

Thanks!

@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into 6573670.

@rust-bors rust-bors Bot force-pushed the allow-backward-incompat-drop-hint branch from 77a6ade to 6573670 Compare July 8, 2026 19:12
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6573670 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158384 - KiChjang:allow-backward-incompat-d…
1d1647e 
…rop-hint, r=lqd

Allow BackwardIncompatibleDropHint in polonius legacy

Fixes rust-lang#157568.

Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 8, 2026
Closed
@lqd

lqd commented Jul 8, 2026

Copy link
Copy Markdown
Member

Darn, why did CI pass before. This will make the rollup fail :(

@bors r-

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 8, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 8, 2026
@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#158973), which was unapproved.

View changes since this unapproval

@KiChjang
Allow BackwardIncompatibleDropHint in polonius legacy
23cf412 
* Allow BackwardIncompatibleDropHint in polonius legacy
* Move test file to be under polonius
* Remove resolved crash test file
@KiChjang KiChjang force-pushed the allow-backward-incompat-drop-hint branch from 6573670 to 23cf412 Compare July 9, 2026 16:37
@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@KiChjang

KiChjang commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@lqd because main changed and added a crash test for the issue. We weren't fast enough :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lqd lqd

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ICE]: Polonius loan_invalidations.rs:86:17: Statement not allowed in this MIR phase

5 participants

@KiChjang @rustbot @lqd @folkertdev @rust-log-analyzer