Skip to content

[experiment] Benchmark -Zthreads=sync on rustc-perf benchmarks #158357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petrochenkov wants to merge 1 commit into from
+2 −2
Closed

[experiment] Benchmark -Zthreads=sync on rustc-perf benchmarks #158357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/rustc_session/src/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ pub mod parse {
// We want to cap the number of threads here to avoid large numbers like 999999 and compiler panics.
// This solution was suggested here https://github.com/rust-lang/rust/issues/117638#issuecomment-1800925067
let n = n.min(MAX_THREADS_CAP);
*slot = (n > 1).then_some(n); // Enable synchronization if we're using more than one thread.
*slot = Some(n);
true
}

Expand Down Expand Up @@ -2753,7 +2753,7 @@ written to standard error output)"),
/// in the future. Note that -Zthreads=0 is the way to get
/// the num_cpus behavior.
#[rustc_lint_opt_deny_field_access("use `Session::threads` instead of this field")]
threads: Option<usize> = (None, parse_threads, [UNTRACKED],
threads: Option<usize> = (Some(1), parse_threads, [UNTRACKED],
"use a thread pool with N threads"),
time_llvm_passes: bool = (false, parse_bool, [UNTRACKED],
"measure time of each LLVM pass (default: no)"),
Expand Down
Loading