Add expansion info to default bounds#158259
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add expansion info to default bounds
|
@bors try cancel seems stuck |
|
Try build cancelled. Cancelled workflows: |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Add expansion info to default bounds
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (6c4a2f9): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.6%, secondary 4.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.1%, secondary 2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 2.3%, secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 505.379s -> 506.981s (0.32%) |
This comment has been minimized.
This comment has been minimized.
d30eea8 to
2811451
Compare
|
While it would be nice to have this, I don't think it's worth all the extra span information that is necessary for it to work (the perf cost is in metadata encoding and actual generation of those spans, as we generate implicit bounds like |
|
nope that's not a good idea either. It breaks a lot of suggestion logic because that doesn't like expansion info. Ok, giving up 😆 |
Relanding part of #158122
The incremental issues are resolved in this PR, but we still need to check perf
r? @ghost