Skip to content

Add expansion info to default bounds#158259

Closed
oli-obk wants to merge 3 commits into
rust-lang:mainfrom
oli-obk:expn-info-default-bounds
Closed

Add expansion info to default bounds#158259
oli-obk wants to merge 3 commits into
rust-lang:mainfrom
oli-obk:expn-info-default-bounds

Conversation

@oli-obk

@oli-obk oli-obk commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Relanding part of #158122

The incremental issues are resolved in this PR, but we still need to check perf

r? @ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2026
@oli-obk

oli-obk commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 22, 2026
@oli-obk

oli-obk commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@bors try cancel seems stuck

@rust-bors

rust-bors Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

@oli-obk

oli-obk commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 22, 2026
@rust-bors

rust-bors Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 6c4a2f9 (6c4a2f95b8d82a704b3d651a5a527b432add2ee8)
Base parent: cddcbec (cddcbec198760511240bf0e728193bf4d700acb4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6c4a2f9): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.6% [0.1%, 3.0%] 80
Regressions ❌
(secondary)
0.6% [0.0%, 1.8%] 58
Improvements ✅
(primary)
-0.2% [-0.3%, -0.1%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [-0.3%, 3.0%] 83

Max RSS (memory usage)

Results (primary 1.6%, secondary 4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.8% [0.5%, 3.2%] 28
Regressions ❌
(secondary)
4.5% [0.7%, 11.5%] 12
Improvements ✅
(primary)
-2.2% [-2.3%, -2.1%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.6% [-2.3%, 3.2%] 30

Cycles

Results (primary 3.1%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.4% [2.0%, 5.2%] 15
Regressions ❌
(secondary)
3.0% [2.1%, 4.3%] 16
Improvements ✅
(primary)
-1.7% [-1.7%, -1.7%] 1
Improvements ✅
(secondary)
-4.2% [-5.3%, -3.1%] 2
All ❌✅ (primary) 3.1% [-1.7%, 5.2%] 16

Binary size

Results (primary 2.3%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [0.0%, 11.9%] 78
Regressions ❌
(secondary)
2.3% [0.0%, 11.4%] 47
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.3% [0.0%, 11.9%] 78

Bootstrap: 505.379s -> 506.981s (0.32%)
Artifact size: 353.06 MiB -> 353.64 MiB (0.16%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 22, 2026
@rust-bors

This comment has been minimized.

@oli-obk oli-obk force-pushed the expn-info-default-bounds branch from d30eea8 to 2811451 Compare June 26, 2026 13:43
@oli-obk

oli-obk commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

While it would be nice to have this, I don't think it's worth all the extra span information that is necessary for it to work (the perf cost is in metadata encoding and actual generation of those spans, as we generate implicit bounds like Sized everywhere. It may be easier to mark the ones that are not implicitly generated

@oli-obk

oli-obk commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

nope that's not a good idea either. It breaks a lot of suggestion logic because that doesn't like expansion info. Ok, giving up 😆

@oli-obk oli-obk closed this Jul 8, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants