Skip to content

Convert '.' to '_' in bootstrap envify #158118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 2 commits into from
Jun 19, 2026
+3 −1
Merged

Convert '.' to '_' in bootstrap envify #158118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9777466
Convert '.' to '_' in bootstrap envify
jonathanpallant Jun 19, 2026
8ef1e86
Add some additional context in envify
jonathanpallant Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/bootstrap/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,9 +2120,11 @@ impl Compiler {
}

fn envify(s: &str) -> String {
// Converting foo-bar to FOO_BAR is a fairly idomatic mapping to an environment variable name.
// We also convert '.' to '_' to fix https://github.com/rust-lang/rust/issues/158090
s.chars()
.map(|c| match c {
'-' => '_',
'-' | '.' => '_',
c => c,
})
.flat_map(|c| c.to_uppercase())
Expand Down
Loading