ci: Enable autodiff tests on x86_64 linux#157776
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
a5999ca to
7da709a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
No problem found |
851ebe4 to
33566ea
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
27ed09b to
57ed38d
Compare
This comment has been minimized.
This comment has been minimized.
57ed38d to
69603c6
Compare
|
Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu |
|
@bors try jobs=x86_64-gnu-autodiff Rerunning to test potential cache effects. |
This comment has been minimized.
This comment has been minimized.
ci: Enable autodiff tests on x86_64 linux try-job: x86_64-gnu-autodiff
|
Rebuilding a second time, since I'm not sure if artifacts are shared between PR Ci and try runs. But so far, even just building LLVM+rustc+std+enzyme takes 95 minutes, 10 minutes more than miri, the next slowest job. Total time will always be a bit more than that, and autodiff will always have less users than something general like Miri, so that's hard to defend. If the try results come back unchanged, can you move it to auto and mark it as allowed to fail? I don't think it needs to be blocking yet. |
This comment has been minimized.
This comment has been minimized.
ci: Enable autodiff tests on x86_64 linux try-job: x86_64-gnu-autodiff
|
@Kobzol @jieyouxu cc: @ZuseZ4
I'll address this in a follow-up PR by adding an autodiff CI page to the rustc-dev-guide and setting it as the job's doc_url. |
|
(BTW you can make the rdg changes in the same PR here modifying the rdg subtree, the rdg url can be predicted (like the autodiff job)) |
|
|
Done! |
|
|
||
| ## Point of contact | ||
|
|
||
| If you have questions or need help with a failure in this job, open a new topic |
There was a problem hiding this comment.
Is there a ping group for autodiff in team? It would be good to have that, and let reviewers ping such a team on the PR directly.
There was a problem hiding this comment.
I don't think we currently have an autodiff notification group. I couldn't find one.
I took a look at the process described here:
https://forge.rust-lang.org/compiler/notification-groups.html#creating-a-notification-group
I'm not sure whether I should go through these steps myself or whether they need to be handled by a Rust team member. Either way, I assume creating the notification group doesn't need to block this PR
|
@bors try jobs=optional-x86_64-gnu-autodiff |
This comment has been minimized.
This comment has been minimized.
ci: Enable autodiff tests on x86_64 linux try-job: optional-x86_64-gnu-autodiff
|
@ZuseZ4 |
|
I was just waiting for LLVM 23 to land, which hopefully is tomorrow. But since it's optional and you tested building under LLVM 23, I guess it doesn't really matter. @bors r+ |
…ZuseZ4 ci: Enable autodiff tests on x86_64 linux ## Summary Enable autodiff tests on x86_64 linux For now, this is an `optional-*` Merge CI only job, and is not enabled in PR CI. r? @ZuseZ4
…ZuseZ4 ci: Enable autodiff tests on x86_64 linux ## Summary Enable autodiff tests on x86_64 linux For now, this is an `optional-*` Merge CI only job, and is not enabled in PR CI. r? @ZuseZ4
Rollup of 18 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #150161 (Remove 'static requirement on try_as_dyn) - #158362 (trait solver: account for universes from replace_bound_vars) - #159173 (Add allowed list check on EII implementations attributes) - #159466 (cmse: clear variant-dependent padding in `enum`s) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #157905 (Update comments and add tests for `-Zrandomize-layout` for some guaranteed ZSTs) - #159041 (Reorganize `tests/ui/issues` [22/N]) - #159108 (Reorganize `tests/ui/issues` [23/N]) - #159138 (doc: document wasm import symbol mangling) - #159531 (Reorganize `tests/ui/issues` [28/N]) - #159608 (early_otherwise: Don't hoist dereferences when the otherwise branch is reachable) - #159612 (Reorganize `tests/ui/issues` [29/N]) - #159653 (run `tests/assembly-llvm/asm/aarch64-types.rs` for `aarch64_be`) - #159759 (rustc-dev-guide subtree update) - #159761 (Remove outdated comment for resolve_vars_with_obligations)
…ZuseZ4 ci: Enable autodiff tests on x86_64 linux ## Summary Enable autodiff tests on x86_64 linux For now, this is an `optional-*` Merge CI only job, and is not enabled in PR CI. r? @ZuseZ4
…ZuseZ4 ci: Enable autodiff tests on x86_64 linux ## Summary Enable autodiff tests on x86_64 linux For now, this is an `optional-*` Merge CI only job, and is not enabled in PR CI. r? @ZuseZ4
Rollup of 19 pull requests Successful merges: - #150161 (Remove 'static requirement on try_as_dyn) - #158362 (trait solver: account for universes from replace_bound_vars) - #159173 (Add allowed list check on EII implementations attributes) - #159466 (cmse: clear variant-dependent padding in `enum`s) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #157905 (Update comments and add tests for `-Zrandomize-layout` for some guaranteed ZSTs) - #158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - #159041 (Reorganize `tests/ui/issues` [22/N]) - #159108 (Reorganize `tests/ui/issues` [23/N]) - #159138 (doc: document wasm import symbol mangling) - #159531 (Reorganize `tests/ui/issues` [28/N]) - #159608 (early_otherwise: Don't hoist dereferences when the otherwise branch is reachable) - #159612 (Reorganize `tests/ui/issues` [29/N]) - #159653 (run `tests/assembly-llvm/asm/aarch64-types.rs` for `aarch64_be`) - #159667 (Make some parser structured suggestions verbose and tweak their wording) - #159759 (rustc-dev-guide subtree update) - #159761 (Remove outdated comment for resolve_vars_with_obligations)
View all comments
Summary
Enable autodiff tests on x86_64 linux
For now, this is an
optional-*Merge CI only job, and is not enabled in PR CI.r? @ZuseZ4