Move NativeLib::filename to the rmeta-link archive member by mehdiakiki · Pull Request #156735 · rust-lang/rust

mehdiakiki · 2026-05-19T01:30:27Z

Second PR in #138243
Moves NativeLib::filename out of rmeta into lib.rmeta-link archive member that was introduced in the first PR. Filename is a link time only data so requiring a full metadata decode should be avoided. It is stored as (name, filename) pairs keyed by name, the new MetadataLoader::get_rlib_native_lib_filenames patches it back on decode. Also bumped METADATA_VERSION from version 10 to 11. Added also new round trip test and existing bundled-libs tests still pass.

rustbot · 2026-05-19T01:30:33Z

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 19 candidates

mehdiakiki · 2026-05-19T02:05:27Z

r? @petrochenkov
cc @bjorn3

mehdiakiki · 2026-05-20T01:24:00Z

Started working on it today. Should have it ready soon.

petrochenkov · 2026-07-03T12:12:15Z

@bors try @rust-timer queue

Move NativeLib::filename to the rmeta-link archive member

rust-bors · 2026-07-03T14:21:17Z

☀️ Try build successful (CI)
Build commit: 2f75410 (2f7541075058da7aa2a74d202935f2d3b0e07464)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

rust-timer · 2026-07-03T15:16:39Z

Finished benchmarking commit (2f75410): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-6.4%, -2.6%]	4
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.944s -> 486.779s (0.17%)
Artifact size: 393.37 MiB -> 393.32 MiB (-0.01%)

mehdiakiki · 2026-07-03T20:47:28Z

Resolved the conflicts
@rustbot ready

petrochenkov · 2026-07-06T14:18:32Z

Could you address the review comments (#156735 (comment) and below)?
@rustbot author

mehdiakiki · 2026-07-08T11:48:47Z

@petrochenkov Yes sure!

petrochenkov · 2026-07-09T20:16:03Z

+                        && let Some(rlib_path) = crate_info.used_crate_source[&cnum].rlib.as_ref()
+                    {
+                        bundled_libs = rmeta_link_cache
+                            .get_or_insert_with(rlib_path, || {


fn native_lib_filenames can be used here too

fn read_from_path can be made private

fn crate_may_have_bundled_libs can be merged into fn native_lib_filenames

View changes since the review

mehdiakiki · 2026-07-09T22:48:57Z

@rustbot ready

petrochenkov · 2026-07-10T05:50:58Z

#156735 (comment)
@rustbot author

rustbot assigned dingxiangfei2009 May 19, 2026

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 19, 2026

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 053432f to 8f96681 Compare May 19, 2026 01:46

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 8f96681 to 5a93c75 Compare May 19, 2026 02:00

rustbot assigned petrochenkov and unassigned dingxiangfei2009 May 19, 2026

petrochenkov reviewed May 19, 2026

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2026

mehdiakiki force-pushed the fix/rlib-digest branch from 5a93c75 to 3b0d8b8 Compare May 20, 2026 01:23

mehdiakiki force-pushed the fix/rlib-digest branch from 3b0d8b8 to e923f64 Compare May 22, 2026 01:08

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from e923f64 to 2414bd9 Compare May 22, 2026 01:14

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 2414bd9 to b0da354 Compare May 22, 2026 01:21

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from b0da354 to 92610ca Compare May 22, 2026 01:27

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 92610ca to 70f18ca Compare May 22, 2026 01:35

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 70f18ca to 578ba56 Compare May 22, 2026 01:42

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jul 2, 2026

petrochenkov added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2026

petrochenkov reviewed Jul 3, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/rmeta_link.rs

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 3, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 3, 2026

Auto merge of #156735 - mehdiakiki:fix/rlib-digest, r=<try>

2f75410

Move NativeLib::filename to the rmeta-link archive member

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2026

mehdiakiki force-pushed the fix/rlib-digest branch from c17c40e to 6ce6345 Compare July 3, 2026 12:59

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Jul 3, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2026

Move NativeLib::filename to the rmeta-link archive member

9bffa6b

mehdiakiki force-pushed the fix/rlib-digest branch from 6ce6345 to 9bffa6b Compare July 9, 2026 19:56

petrochenkov reviewed Jul 9, 2026

View reviewed changes

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 9, 2026

Uh oh!

Uh oh!

Conversation

mehdiakiki commented May 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mehdiakiki commented May 19, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mehdiakiki commented May 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jul 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 3, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 3, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

mehdiakiki commented Jul 3, 2026

Uh oh!

petrochenkov commented Jul 6, 2026

Uh oh!

mehdiakiki commented Jul 8, 2026

Uh oh!

petrochenkov Jul 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mehdiakiki commented Jul 9, 2026

Uh oh!

petrochenkov commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mehdiakiki commented May 19, 2026 •

edited by rustbot

Loading

petrochenkov Jul 9, 2026 •

edited by rustbot

Loading