Remove redundancy and fix padding on some bytes display function

[yhx-12243]

Remove redundancy and fix padding on some bytes display function, based on the discussion on #134915 (comment).

[rustbot]

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ChrisDenton]

@rustbot author it seems like this does make a difference in debug output?

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[yhx-12243]

@rustbot author it seems like this does make a difference in debug output?

Indeed. Maybe one can discuss whether it is worth divided into two implentations.

[Dylan-DPC]

@yhx-12243 this has merge commits which are against the policy as linked above. Kindly make the respective changes

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-log-analyzer]

The job x86_64-gnu-gcc-core-tests failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- bstr::test_debug stderr ----

thread 'main' (18645) panicked at library/coretests/tests/bstr.rs:5:5:
assertion `left == right` failed
  left: "\"\\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07\\x08\\t\\n\\x11\\x12\\r\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f \\x7f\\x80\\x81\\xfe\\xff\""
 right: "\"\\0\\u{1}\\u{2}\\u{3}\\u{4}\\u{5}\\u{6}\\u{7}\\u{8}\\t\\n\\u{11}\\u{12}\\r\\u{14}\\u{15}\\u{16}\\u{17}\\u{18}\\u{19}\\u{1a}\\u{1b}\\u{1c}\\u{1d}\\u{1e}\\u{1f} \\u{7f}\\x80\\x81\\xFE\\xFF\""
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- bstr::test_debug stdout end ----
---- ffi::cstr::debug stdout ----
---- ffi::cstr::debug stderr ----

thread 'main' (18860) panicked at library/coretests/tests/ffi/cstr.rs:26:5:
assertion `left == right` failed
  left: "\"abc\\u{1}\\u{2}\\n…\\xFF\""
 right: "\"abc\\x01\\x02\\n…\\xff\""
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- ffi::cstr::debug stdout end ----

failures:

Important

For more information how to resolve CI failures of this job, visit this link.