Create Atomic<T> type alias#130543
Conversation
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
This comment was marked as outdated.
This comment was marked as outdated.
bacfd33 to
cc104b1
Compare
|
Alright that's the merge conflicts fixed. If I end up needing to continue playing catch-up on some of the touched files, I'll probably just drop files' touch-up to use |
This comment has been minimized.
This comment has been minimized.
|
r=me after fixing the import issues |
67a79e8 to
fbf092e
Compare
|
Also found a similar conflict with the windows futex impl plumbing via local check, so that's also resolved by the amend (hopefully; my local checkout suddenly is complaining about duplicate rmeta for crate IIRC I don't have perms to do this but might as well try: @bors r=Noratrieb rollup=iffy |
|
@CAD97: 🔑 Insufficient privileges: Not in reviewers |
|
@CAD97: 🔑 Insufficient privileges: not in try users |
|
@bors r=Noratrieb rollup=iffy |
This comment has been minimized.
This comment has been minimized.
in core/alloc/std only for now, and ignoring test files Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
|
That should be fixed now @rustbot review |
|
@bors r+ |
|
☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
🤦 Will fix that when I get a chance. @rustbot author |
|
This got merged in #136316, so it can now be closed, I think |
and use it in core/alloc/std where possible, ignoring test files for now.
This is step one, creating the alias from
Atomic<T>toAtomicT. The next step of flipping this and aliasingAtomicTtoAtomic<T>will have a bigger impact, sinceAtomicTimports can be dropped onceAtomic::newis a usable name.First commit is the true change. Second commit is mostly mechanical replacement of
AtomicTtype names withAtomic<T>.See how this was done for
NonZerofor the rough blueprint I'm following.Atomic<T>libs-team#443 (comment)Atomic#130539