Add `format_in_format_args` and `to_string_in_format_args` lints by smoelius · Pull Request #7743 · rust-lang/rust-clippy

smoelius · 2021-09-30T13:01:50Z

I put these in perf since that was one of @jplatte's suggestions, and redundant_clone (which I consider to be similar) lives there as well.

However, I am open to changing the category or anything else.

r? @camsteffen

changelog: Add format_in_format_args and to_string_in_format_args lints

smoelius · 2021-09-30T14:03:12Z

Sorry for the late addition. I added two more test cases.

smoelius · 2021-10-02T13:04:37Z

I pushed the changes using bitflags.

bitflags 1.2 is already in rust's lockfile, so hopefully this won't be a problem: https://github.com/rust-lang/rust/blob/a8387aef8c378a771686878062e544af4d5e2245/Cargo.lock#L125

Please let me know what other changes are needed.

bors · 2021-10-03T08:56:59Z

☔ The latest upstream changes (presumably #7709) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2021-10-06T07:53:50Z

☔ The latest upstream changes (presumably #7773) made this pull request unmergeable. Please resolve the merge conflicts.

smoelius · 2021-10-07T19:14:52Z

@camsteffen I apologize for the delay. The Deref case was trickier than I expected. I think the most recent push addresses all of your comments up to this point.

bors · 2021-10-08T07:45:18Z

☔ The latest upstream changes (presumably #7748) made this pull request unmergeable. Please resolve the merge conflicts.

camsteffen

No problem at all!

Okay, I have another round of feedback. We're definitely getting closer. This may be the most complex macro processing that Clippy has even seen so really great work!

smoelius · 2021-10-11T12:22:22Z

I think I'm ready for the next round of feedback, @camsteffen. Thanks for doing this.

camsteffen

I think we're nearing the end now. Thanks for sticking with it.

bors · 2021-10-12T18:52:11Z

☔ The latest upstream changes (presumably #7806) made this pull request unmergeable. Please resolve the merge conflicts.

smoelius · 2021-10-14T09:22:12Z

@camsteffen The paths I added to path.rs appear to be the only ones that refer to macros. I am guessing this is why INVALID_PATHS is failing. Assuming this is right, do you have any suggestions on how to fix it?

camsteffen · 2021-10-14T19:27:40Z

@camsteffen The paths I added to path.rs appear to be the only ones that refer to macros. I am guessing this is why INVALID_PATHS is failing. Assuming this is right, do you have any suggestions on how to fix it?

@smoelius I'd probably have to debug the invalid_paths lint to figure it out. But the paths should be migrated to diagnostic items anyways so it's kinda not worth the effort. So it's okay to use paths for now and allow the lint on those items with a todo. Or, if you feel inclined, you can add the diagnostic items in rustc and wait for them to be synced in the following Rustup PR.

smoelius · 2021-10-14T23:06:43Z

it's okay to use paths for now and allow the lint on those items with a todo.

OK, that's what I did.

I also did some optimistic squashing. But I can undo it if it's a problem.

camsteffen

Please squash the last commit and this is ready to merge!

Fixes rust-lang#7667 and rust-lang#7729

smoelius · 2021-10-15T16:55:56Z

Thanks very much for your patience, @camsteffen.

camsteffen · 2021-10-15T17:05:08Z

You bet. Thanks for the PR!

@bors r+

bors · 2021-10-15T17:05:09Z

📌 Commit 75e9f8c has been approved by camsteffen

bors · 2021-10-15T17:05:16Z

⌛ Testing commit 75e9f8c with merge e1871ba...

bors · 2021-10-15T17:17:12Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing e1871ba to master...

rust-highfive assigned camsteffen Sep 30, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2021

camsteffen reviewed Sep 30, 2021

View reviewed changes

Comment thread clippy_utils/src/format.rs Outdated

Comment thread clippy_lints/src/format_args.rs Outdated

smoelius force-pushed the master branch from de5ba31 to 8ce9257 Compare October 2, 2021 15:48

smoelius force-pushed the master branch from 8ce9257 to d54fc50 Compare October 3, 2021 21:28

camsteffen suggested changes Oct 4, 2021

View reviewed changes

camsteffen added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 5, 2021

smoelius force-pushed the master branch from 83809b4 to c1d20e7 Compare October 7, 2021 18:53

smoelius force-pushed the master branch from c1d20e7 to 596a02f Compare October 8, 2021 16:35

camsteffen suggested changes Oct 8, 2021

View reviewed changes

camsteffen suggested changes Oct 12, 2021

View reviewed changes

smoelius force-pushed the master branch from 88ed33c to 571f4eb Compare October 14, 2021 01:05

smoelius force-pushed the master branch from 571f4eb to a78c7fd Compare October 14, 2021 22:57

camsteffen reviewed Oct 15, 2021

View reviewed changes

Comment thread clippy_lints/src/format_args.rs Outdated

camsteffen approved these changes Oct 15, 2021

View reviewed changes

smoelius added 3 commits October 15, 2021 12:44

Add format_in_format_args and to_string_in_format_args lints

c9599d7

Fixes rust-lang#7667 and rust-lang#7729

Fix adjacent tests

47014d8

Remove redundant to_strings

75e9f8c

smoelius force-pushed the master branch from c822b5f to 75e9f8c Compare October 15, 2021 16:46

bors merged commit e1871ba into rust-lang:master Oct 15, 2021

This was referenced Oct 15, 2021

[bool_assert_comparaison] improve suggestion #7612

Closed

Move if_then_panic to pedantic and rename to manual_assert #7810

Merged

This was referenced Nov 12, 2021

FN useless_format: write!(f,"{}",format!()) #3155

Closed

Should pick up panic!(format!( #5013

Closed

Lint against panic!(format!(...)) and assert!(..., format!(...)) #6259

Closed

smoelius mentioned this pull request Dec 9, 2024

Make inconsistent_struct_constructor "all fields are shorthand" requirement configurable #13737

Merged

Uh oh!

Uh oh!

Conversation

smoelius commented Sep 30, 2021

Uh oh!

smoelius commented Sep 30, 2021

Uh oh!

Uh oh!

Uh oh!

smoelius commented Oct 2, 2021

Uh oh!

bors commented Oct 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Oct 6, 2021

Uh oh!

smoelius commented Oct 7, 2021

Uh oh!

bors commented Oct 8, 2021

Uh oh!

camsteffen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smoelius commented Oct 11, 2021

Uh oh!

camsteffen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Oct 12, 2021

Uh oh!

smoelius commented Oct 14, 2021

Uh oh!

camsteffen commented Oct 14, 2021

Uh oh!

smoelius commented Oct 14, 2021

Uh oh!

Uh oh!

camsteffen left a comment

Choose a reason for hiding this comment

Uh oh!

smoelius commented Oct 15, 2021

Uh oh!

camsteffen commented Oct 15, 2021

Uh oh!

bors commented Oct 15, 2021

Uh oh!

bors commented Oct 15, 2021

Uh oh!

bors commented Oct 15, 2021

Uh oh!

Reviewers

Assignees

Labels