rustup "Cheaper doc comments"#4755
Closed
tesuji wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
cc @nnethercote |
Contributor
Author
|
Tests passed locally with stage2 compiler from rust-lang/rust#65750 |
Contributor
Author
Clippy is portable on *nix OSes. It is really rare to see clippy broken on either macOS and Linux. So let's test it on bors branches only to save CI time.
tesuji
commented
Nov 7, 2019
| db.cancel(); | ||
| attr_segments[1].ident.to_string() == name | ||
| }, | ||
| if attr.is_doc_comment() { |
Contributor
Author
There was a problem hiding this comment.
I think i should split this closure to a separate function.
Member
|
closing in favor of #4788 (smaller diff) |
Member
Contributor
Author
|
I think #4788 is nicer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustup rust-lang/rust#65750
changelog: none