Skip to content

Allow everyone to assign labels with rustbot#4595

Merged
bors merged 1 commit into
masterfrom
rustbot
Oct 8, 2019
Merged

Allow everyone to assign labels with rustbot#4595
bors merged 1 commit into
masterfrom
rustbot

Conversation

@oli-obk

@oli-obk oli-obk commented Sep 28, 2019

Copy link
Copy Markdown
Contributor

Also allows people to claim issues even if they aren't part of the org

changelog: none

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 28, 2019

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@flip1995

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 79c4543 has been approved by flip1995

@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 79c4543 with merge d7fd041...

bors added a commit that referenced this pull request Sep 30, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@llogiq

llogiq commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

Looks like some loop lint broke?

@tesuji

tesuji commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

@bors retry ?

@bors

bors commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

@lzutao: 🔑 Insufficient privileges: not in try users

@phansch

phansch commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 79c4543 with merge d7ea4ee...

bors added a commit that referenced this pull request Oct 3, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors

bors commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@phansch

phansch commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

@bors retry may have been spurious (error: no such subcommand: +nightly)

bors added a commit that referenced this pull request Oct 3, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors

bors commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 79c4543 with merge e788902...

@bors

bors commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@phansch

phansch commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

@bors retry

@phansch

phansch commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

hey @bors are you still there?

@bors

bors commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

🍰 Activated

@phansch

phansch commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

@bors retry (or do I have to r=flip1995?)

@phansch

phansch commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

@bors r=flip1995

@bors

bors commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 79c4543 has been approved by flip1995

@mati865

mati865 commented Oct 4, 2019

Copy link
Copy Markdown
Member

It has to wait on #4628

Looking at https://buildbot2.rust-lang.org/homu/queue/clippy bors is stuck on #4627

@phansch

phansch commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

Oh thanks, I was just expecting the approved message, but I guess that is only posted when it's first approved

bors added a commit that referenced this pull request Oct 8, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors

bors commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 79c4543 with merge bbad77a...

@bors

bors commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing bbad77a to master...

@bors
bors merged commit 79c4543 into master Oct 8, 2019
@flip1995
flip1995 deleted the rustbot branch October 28, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants