Skip to content

Add rustfix tests for mistyped_literal_suffix lint#3888

Merged
bors merged 3 commits into
rust-lang:masterfrom
phansch:extract_mistyped_literal_suffix_tests_and_rustfix
Mar 19, 2019
Merged

Add rustfix tests for mistyped_literal_suffix lint#3888
bors merged 3 commits into
rust-lang:masterfrom
phansch:extract_mistyped_literal_suffix_tests_and_rustfix

Conversation

@phansch

@phansch phansch commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

This moves all mistyped_literal_suffix tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887

@flip1995

Copy link
Copy Markdown
Member

Rustfmt on tests/ui/mistyped_literal_suffix.rs required. After that r=me (Just merge this directly instead of #3887 first)

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Mar 15, 2019
@phansch

phansch commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

0ba45a9 should make the build pass once Clippy builds again. I'm not available until Monday so feel free to r+ once it works =)

@flip1995

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 0ba45a9 has been approved by flip1995

@flip1995

Copy link
Copy Markdown
Member

Oh wait #3893 isn't merged yet

@bors r-

@phansch

phansch commented Mar 18, 2019

Copy link
Copy Markdown
Contributor Author

@bors r=flip1995

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 0ba45a9 has been approved by flip1995

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 0ba45a9 with merge 65ed3dd...

bors added a commit that referenced this pull request Mar 18, 2019
…nd_rustfix, r=flip1995

Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

phansch added 3 commits March 19, 2019 06:55
The moved tests were part of `tests/ui/literals.rs` before. Now they are
placed in `tests/ui/unreadable_literal.rs`, which now also runs
`rustfix` on these 4 extra let statements.
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc rust-lang#3603, rust-lang#2038

Based on rust-lang#3887
@phansch
phansch force-pushed the extract_mistyped_literal_suffix_tests_and_rustfix branch from 0ba45a9 to 0452704 Compare March 19, 2019 05:57
@phansch

phansch commented Mar 19, 2019

Copy link
Copy Markdown
Contributor Author

@bors r=flip1995

@bors

bors commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 0452704 has been approved by flip1995

@bors

bors commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 0452704 with merge c7d4445...

bors added a commit that referenced this pull request Mar 19, 2019
…nd_rustfix, r=flip1995

Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
@bors

bors commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing c7d4445 to master...

@bors
bors merged commit 0452704 into rust-lang:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants