Integrate rustfix into Clippy test suite#3519
Merged
Merged
Conversation
Contributor
Author
|
It looks like it already found an incorrect suggestion for the |
Contributor
Author
|
@bors hello? |
Contributor
|
😪 I'm awake I'm awake |
phansch
added
the
S-blocked
phansch
changed the title
This comment has been minimized.
This comment has been minimized.
phansch
force-pushed
the
brave_newer_ui_tests
branch
from
December 12, 2018 06:46
bf6792b to
3270724
Compare
flip1995
approved these changes
Dec 12, 2018
flip1995
left a comment
flip1995
left a comment
Member
There was a problem hiding this comment.
Nice! r=me when Manishearth/compiletest-rs#151 is merged and the dependency is adapted
This comment has been minimized.
This comment has been minimized.
phansch
force-pushed
the
brave_newer_ui_tests
branch
from
December 28, 2018 20:06
3270724 to
298aedf
Compare
phansch
added
S-waiting-on-author
phansch
commented
Jan 3, 2019
Contributor
Author
|
@bors r=flip1995 🚀 I will write up a tracking issue for adding rustfix coverage later today. |
Contributor
|
📌 Commit ec1395a has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jan 3, 2019
Integrate rustfix into Clippy test suite Once the [PR to compiletest-rs](Manishearth/compiletest-rs#151) is reviewed and merged this fixes #2376. I will create a separate tracking issue for adding `run-rustfix` to all tests.
phansch
removed
the
S-waiting-on-author
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the PR to compiletest-rs is reviewed and merged this fixes #2376.
I will create a separate tracking issue for adding
run-rustfixto all tests.