Respect the configured MSRV in implicit_saturating_sub's if x != 0 { x -= 1 } rewrite#17404
Open
shulaoda wants to merge 1 commit into
Open
Respect the configured MSRV in implicit_saturating_sub's if x != 0 { x -= 1 } rewrite#17404shulaoda wants to merge 1 commit into
implicit_saturating_sub's if x != 0 { x -= 1 } rewrite#17404shulaoda wants to merge 1 commit into
Conversation
… { x -= 1 }` rewrite
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Gri-ffin
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17403
implicit_saturating_subrewritesif x != 0 { x -= 1 }intox = x.saturating_sub(1).saturating_subis only usable in aconst fnsince Rust 1.47, so in aconst fnwith a lower configured MSRV the rewrite does not compile.#16309 already added this MSRV check to the
if a >= b { 0 } else { b - a }path, but the condition path (if x != 0 { x -= 1 }) was left unguarded. This threads the MSRV into that path and applies the same check, so the lint stays quiet when the suggestedsaturating_subwould be too new for the const context.The lint reads the MSRV but was missing from the list of MSRV affected lints in the configuration docs, so this registers it there as well.
changelog: [
implicit_saturating_sub]: respect the configured MSRV in const contexts for theif x != 0 { x -= 1 }rewrite