Skip to content

Add new lint getter_prefixes - #16452

Open
faeroon wants to merge 1 commit into
rust-lang:masterfrom
faeroon:issues/w1673
Open

Add new lint getter_prefixes#16452
faeroon wants to merge 1 commit into
rust-lang:masterfrom
faeroon:issues/w1673

Conversation

@faeroon

@faeroon faeroon commented Jan 24, 2026

Copy link
Copy Markdown

implemented new check getter prefixes lint and meet UI test error

changelog: [getter_prefixes]

  • Followed [lint naming conventions][lint_naming]
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

Fixes #1673. Based on comments of previous PR #3616. Changes comparing to previous:

  1. lint checks only public inherent associated methods with return type
  2. lint checks method bodies have trivial logic and return inner state

@rustbot rustbot added needs-fcp PRs that add, remove, or rename lints and need an FCP S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 24, 2026
@rustbot

rustbot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions

github-actions Bot commented Jan 24, 2026

Copy link
Copy Markdown

Lintcheck changes for e0a60fe

Lint Added Removed Changed
clippy::getter_prefixes 290 0 0

This comment will be updated if you push new changes

@faeroon
faeroon marked this pull request as draft January 24, 2026 19:51
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 24, 2026
@faeroon faeroon changed the title [WIP] implement getter_prefixes lint implement getter_prefixes lint Feb 11, 2026
@faeroon
faeroon marked this pull request as ready for review February 11, 2026 03:49
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 11, 2026
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

rustbot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@faeroon faeroon changed the title implement getter_prefixes lint Add new lint getter_prefixes Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp PRs that add, remove, or rename lints and need an FCP S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint set_* and get_* methods that do nothing but access the field

3 participants