New lint [`absolute_paths`] by Centri3 · Pull Request #11003 · rust-lang/rust-clippy

Centri3 · 2023-06-22T02:21:25Z

Maybe we should make the max segments allowed a configuration option? I see quite a bit of 3-segment paths in clippy, and while I think only really <mod/type>::<item> or <item> should be (usually) used but anything above may be too widespread 😕

PS, despite this being "max segments allowed" it only lints if it's absolute, as is the point of the lint, e.g., std::io::ErrorKind::etc is linted but io::ErrorKind::NotFound::etc isn't

changelog: New lint [absolute_paths]

rustbot · 2023-06-22T02:21:30Z

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

bors · 2023-06-27T18:45:03Z

☔ The latest upstream changes (presumably #10884) made this pull request unmergeable. Please resolve the merge conflicts.

Alexendoo · 2023-06-27T19:43:42Z

Would you like to take a look at this one @blyxyas? (If you have a bunch on your plate already please say so)

blyxyas · 2023-06-28T13:23:49Z

Yeah, I'll take a look!

blyxyas

I think we should have an option to enable std uses with any levels. For example, in my projects I usually leave std functions with their absolute paths to show that they are from the standard library.

Centri3 · 2023-06-28T14:01:33Z

in my projects I usually leave std functions with their absolute paths to show that they are from the standard library.

ra actually colors such functions differently, not sure whether that works across all IDEs though

blyxyas · 2023-06-28T14:03:46Z

ra actually colors such functions differently

This is the first time I hear about this 🤯
But I still thinking having a config value to allow those paths would be neat, as probably a lot of people don't know that that happens.

blyxyas · 2023-06-28T14:06:04Z

Update: I'm not seeing those colors 😞
Edit: Not even on the pre-release version? What version are you on?

Centri3 · 2023-06-28T14:08:00Z

Hmm weird. I'm using one dark pro with vscode (yes, I'm boring) and I see this:

What theme are you using?

I'm on a slightly older pre-release version as I tried seeing if a newer version caused a couple issues (it did not). I'll see if that's the cause (but I don't think so).
^ No change. We should probably discuss this elsewhere though.

e: one dark pro supports support.function.std.rust. It seems to just be up to the theme author to support it, but ra should support it itself everywhere

blyxyas · 2023-06-28T14:20:55Z

Just updated VSCode to the latest version, changed theme to One Dark Pro and reloaded RA. It works now.
... It's... it's probably still a good idea to make this change.

Centri3 · 2023-06-28T14:23:31Z

Yeah I still agree adding a configuration option is a good idea

bors · 2023-07-01T15:44:16Z

☔ The latest upstream changes (presumably #11020) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-07-08T19:42:28Z

☔ The latest upstream changes (presumably #10788) made this pull request unmergeable. Please resolve the merge conflicts.

blyxyas · 2023-07-12T22:12:50Z

@rustbot label: -I-nominated

bors · 2023-07-13T13:11:31Z

☔ The latest upstream changes (presumably #11095) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-07-18T13:11:04Z

☔ The latest upstream changes (presumably #11140) made this pull request unmergeable. Please resolve the merge conflicts.

Alexendoo · 2023-07-18T16:04:14Z

You can only pass flags to cargo test with the uitest alias because of how the others are defined

rust-clippy/.cargo/config.toml

Lines 2 to 4 in 9f0cbfd

    
           uitest = "test --test compile-test" 
        
           uibless = "test --test compile-test -- -- --bless" 
        
           bless = "test -- -- --bless"

Centri3 · 2023-07-18T16:10:13Z

Interesting, I'll keep that in mind, though I'm not sure why BLESS didn't work then (I tried that as well)

Nevermind BLESS= works fine?? That would make sense if it worked before, I'm not sure what I was doing wrong before then

Alexendoo · 2023-07-18T20:06:53Z

Oh and remember to update the config value names if the lint name changes

bors · 2023-07-20T02:27:54Z

☔ The latest upstream changes (presumably #11107) made this pull request unmergeable. Please resolve the merge conflicts.

Alexendoo · 2023-07-21T21:55:10Z

Thanks! r=me,blyxyas with squashed commits

Alexendoo

oop, actually a couple things but then it's good

The commit message calls it absolute_symbol_paths still also

Alexendoo · 2023-07-21T22:29:14Z

👍

@bors r=Alexendoo,blyxyas

bors · 2023-07-21T22:29:16Z

📌 Commit 9cf1509 has been approved by Alexendoo,blyxyas

It is now in the queue for this repository.

bors · 2023-07-21T22:29:21Z

⌛ Testing commit 9cf1509 with merge 58df1e6...

bors · 2023-07-21T22:41:18Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo,blyxyas
Pushing 58df1e6 to master...

rustbot assigned Alexendoo Jun 22, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2023

Centri3 force-pushed the absolute_path branch from 12c600c to 69d4cb3 Compare June 22, 2023 02:43

Centri3 force-pushed the absolute_path branch from 69d4cb3 to 4d7a22b Compare June 27, 2023 21:09

blyxyas reviewed Jun 28, 2023

View reviewed changes

Comment thread clippy_lints/src/absolute_symbol_paths.rs Outdated

Comment thread clippy_lints/src/absolute_symbol_paths.rs Outdated

Comment thread tests/ui/absolute_symbol_paths.rs Outdated

Centri3 force-pushed the absolute_path branch from 4d7a22b to 4061667 Compare June 29, 2023 07:17

Alexendoo assigned blyxyas Jun 29, 2023

Centri3 force-pushed the absolute_path branch from 4061667 to 4f23676 Compare July 1, 2023 17:35

blyxyas reviewed Jul 2, 2023

View reviewed changes

Comment thread clippy_lints/src/utils/conf.rs Outdated

Comment thread tests/ui-toml/absolute_symbol_paths/absolute_symbol_paths.rs Outdated

blyxyas approved these changes Jul 5, 2023

View reviewed changes

Alexendoo reviewed Jul 5, 2023

View reviewed changes

Centri3 force-pushed the absolute_path branch from 8a7f8c1 to b14afbe Compare July 10, 2023 04:01

Alexendoo added the I-nominated Issue: Nominated to be discussed at the next Clippy meeting label Jul 11, 2023

rustbot removed the I-nominated Issue: Nominated to be discussed at the next Clippy meeting label Jul 12, 2023

Centri3 force-pushed the absolute_path branch 2 times, most recently from f8a4ec2 to 38b871f Compare July 14, 2023 01:48

Centri3 force-pushed the absolute_path branch from 6fadcab to 739413c Compare July 18, 2023 16:14

Alexendoo reviewed Jul 18, 2023

View reviewed changes

Centri3 changed the title ~~New lint [absolute_symbol_paths]~~ New lint [absolute_paths] Jul 19, 2023

Centri3 force-pushed the absolute_path branch 5 times, most recently from c5e0a11 to c1028af Compare July 19, 2023 09:29

Alexendoo approved these changes Jul 21, 2023

View reviewed changes

Centri3 force-pushed the absolute_path branch 2 times, most recently from f8b418d to 8d23767 Compare July 21, 2023 21:57

Alexendoo reviewed Jul 21, 2023

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread book/src/lint_configuration.md

Comment thread clippy_lints/src/utils/conf.rs Outdated

New lint absolute_paths

9cf1509

Centri3 force-pushed the absolute_path branch from 8d23767 to 9cf1509 Compare July 21, 2023 22:27

bors merged commit 58df1e6 into rust-lang:master Jul 21, 2023

Centri3 deleted the absolute_path branch July 21, 2023 22:41

This was referenced Jul 21, 2023

New lint [ptr_to_temporary] #10962

Closed

New lint [bare_dos_device_names] #11062

Closed

New lints for literal suffixes #11149

Closed

Change defaults of accept-comment-above-statement and accept-comment-above-attributes #11170

Merged

Uh oh!

Uh oh!

Conversation

Centri3 commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2023

Uh oh!

bors commented Jun 27, 2023

Uh oh!

Alexendoo commented Jun 27, 2023

Uh oh!

blyxyas commented Jun 28, 2023

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centri3 commented Jun 28, 2023

Uh oh!

blyxyas commented Jun 28, 2023

Uh oh!

blyxyas commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centri3 commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blyxyas commented Jun 28, 2023

Uh oh!

Centri3 commented Jun 28, 2023

Uh oh!

bors commented Jul 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Jul 8, 2023

Uh oh!

blyxyas commented Jul 12, 2023

Uh oh!

bors commented Jul 13, 2023

Uh oh!

bors commented Jul 18, 2023

Uh oh!

Alexendoo commented Jul 18, 2023

Uh oh!

Centri3 commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alexendoo commented Jul 18, 2023

Uh oh!

bors commented Jul 20, 2023

Uh oh!

Alexendoo commented Jul 21, 2023

Uh oh!

Alexendoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alexendoo commented Jul 21, 2023

Uh oh!

bors commented Jul 21, 2023

Uh oh!

Centri3 commented Jun 22, 2023 •

edited

Loading

blyxyas commented Jun 28, 2023 •

edited

Loading

Centri3 commented Jun 28, 2023 •

edited

Loading

Centri3 commented Jul 18, 2023 •

edited

Loading

Alexendoo left a comment •

edited

Loading