fix: handle control flows for convert_iter_for_each_to_for#22752
Open
A4-Tacks wants to merge 1 commit into
Open
fix: handle control flows for convert_iter_for_each_to_for#22752A4-Tacks wants to merge 1 commit into
A4-Tacks wants to merge 1 commit into
Conversation
Example
---
```rust
fn main() {
let x = vec![1, 2, 3];
for $0v in x {
if v == 2 {
continue;
}
if v == 3 {
break;
}
v *= 2;
}
}
```
**Before this PR**
```rust
fn main() {
let x = vec![1, 2, 3];
x.into_iter().for_each(|v| {
if v == 2 {
continue;
}
if v == 3 {
break;
}
v *= 2;
});
}
```
**After this PR**
```rust
fn main() {
let x = vec![1, 2, 3];
x.into_iter().try_for_each(|v| {
if v == 2 {
return ControlFlow::Continue(());
}
if v == 3 {
return ControlFlow::Break(());
}
v *= 2;
ControlFlow::Continue(())
});
}
```
5806438 to
481f6d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11111
Example
Before this PR
After this PR