fix: resolve path on all namespace on resolve_path#22743
Open
dfireBird wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
dfireBird
changed the title
dfireBird
force-pushed
the
fix-nameref-classify
branch
from
9faf499 to
ad1c7c1
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
I don't think "half work" is a descriptive commit name 😅 Feel free to squash. |
Contributor
|
Also for Clippy you need to rebase on master. |
Member
Author
I just pushed didn't think much with that 😅
I rebased a bit early lol. |
dfireBird
force-pushed
the
fix-nameref-classify
branch
from
ad1c7c1 to
816b5e8
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
dfireBird
force-pushed
the
fix-nameref-classify
branch
from
816b5e8 to
f441e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @ChayimFriedman2 for the initial work.