Skip to content

chore: remove UnindexinedProject notification #17395

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidbarsky:david/remove-unindexed-project-notification
Jul 23, 2024
Merged

chore: remove UnindexinedProject notification #17395
bors merged 1 commit into
rust-lang:masterfrom
davidbarsky:david/remove-unindexed-project-notification

Conversation

@davidbarsky

Copy link
Copy Markdown
Contributor

This PR is split out from #17246 (and contains its changes, which is a little annoying from a review perspective...). I'd like to land this change a week or so after #17246 lands in order to give any users of the unindexed project notification time to adopt migrate.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2024
@davidbarsky
davidbarsky force-pushed the david/remove-unindexed-project-notification branch from 25300f1 to 46c3ffe Compare June 11, 2024 18:02
@bors

bors commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #17455) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril

Veykril commented Jul 20, 2024

Copy link
Copy Markdown
Member

Just to check, is this resolved within#17246, or does this contain other changes (and just needs a rebase)?

@davidbarsky

davidbarsky commented Jul 20, 2024

Copy link
Copy Markdown
Contributor Author

This one contains a few other changes and needs a rebase. I'll land it after monday's release in case there are any users of this.

@davidbarsky
davidbarsky force-pushed the david/remove-unindexed-project-notification branch from 46c3ffe to 7eff641 Compare July 23, 2024 14:15
@davidbarsky
davidbarsky marked this pull request as ready for review July 23, 2024 14:15
@davidbarsky
davidbarsky force-pushed the david/remove-unindexed-project-notification branch 2 times, most recently from 5cef2c6 to 2040a95 Compare July 23, 2024 15:01
@davidbarsky
davidbarsky requested a review from Veykril July 23, 2024 16:11
Comment thread editors/code/src/main.ts
const RUST_PROJECT_CONTEXT_NAME = "inRustProject";

// This API is not stable and may break in between minor releases.
export interface RustAnalyzerExtensionApi {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the type itself just with the client property, that's what we used to have iirc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done; kept it.

@Veykril

Veykril commented Jul 23, 2024

Copy link
Copy Markdown
Member

@bors delegate+

@bors

bors commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

✌️ @davidbarsky, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@davidbarsky
davidbarsky force-pushed the david/remove-unindexed-project-notification branch from 2040a95 to 2783aa7 Compare July 23, 2024 17:34
@davidbarsky

Copy link
Copy Markdown
Contributor Author

@bors r=@Veykril

@bors

bors commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 2783aa7 has been approved by Veykril

It is now in the queue for this repository.

@bors

bors commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2783aa7 with merge eb5da56...

@bors

bors commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing eb5da56 to master...

@bors
bors merged commit eb5da56 into rust-lang:master Jul 23, 2024
bors added a commit that referenced this pull request Aug 16, 2024
Remove rust-analyzer.workspace.discoverProjectRunner

The functionality for this vscode config option was removed in #17395, so it doesn't do anything anymore.
@davidbarsky
davidbarsky deleted the david/remove-unindexed-project-notification branch November 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants