Skip to content

Update to rustc sanity check branch#381

Merged
RalfJung merged 6 commits into
masterfrom
sanity_checks
Jul 30, 2018
Merged

Update to rustc sanity check branch#381
RalfJung merged 6 commits into
masterfrom
sanity_checks

Conversation

@oli-obk

@oli-obk oli-obk commented Jun 5, 2018

Copy link
Copy Markdown
Contributor

to be merged after rust-lang/rust#51361 hits nightly

@oli-obk oli-obk self-assigned this Jun 5, 2018
@oli-obk
oli-obk force-pushed the sanity_checks branch 2 times, most recently from b8147ed to 062cf07 Compare July 17, 2018 15:53
@RalfJung

Copy link
Copy Markdown
Member

I updated this to also fix the breakage from promoteds being a place.

However, two compile-fail tests fail: A bad bool is no longer detected on an if, and modifying_constants.rs also just runs to completion.

@RalfJung

RalfJung commented Jul 24, 2018

Copy link
Copy Markdown
Member

Yeah the bool part is ensure_valid_value being removed.

I have plans for a more consistent version of this so I guess it's okay for that to be removed, but why is it not even detected when an if actually happens?

EDIT: Ah, the MIR actually uses switchInt(move _2) -> [false: bb2, otherwise: bb1] so it does not care.

@RalfJung

Copy link
Copy Markdown
Member

Note to self and everybody whom it concerns: Do NOT force-push to this branch or delete it before it was merged! It is referenced by rustc.

(Might be worth stating that also in the future as it's kind of not clear just looking at this PR.^^)

oli-obk and others added 5 commits July 26, 2018 11:21
the bool thing will be fixed by the validation I have planned, and we already ignored another test around modifing constants.
@RalfJung
RalfJung merged commit 471944b into master Jul 30, 2018
@RalfJung
RalfJung deleted the sanity_checks branch July 30, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants