You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think the ESP IDF's SOMAXCONN value of 128 is correct either, given that LwIP supports at most 10 to 16 sockets.
BUT: Not so important for ESP IDF really because
(a) I already PR-ed a fix to Rust STD for ESP IDF-specifically, which removes the SOMAXCONN usage; the PR was merged last week
(b) The breakage of STD is w.r.t. Unix domain sockets, which are not a thing on ESP IDF anyway and if the usert tries to use these, they would return a runtime error (we just wanted STD to compile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std is broken on PS Vita since rust-lang/rust#119026
esp-idf's SOMAXCONN from https://github.com/espressif/esp-idf/blob/b3f7e2c8a4d354df8ef8558ea7caddc07283a57b/components/newlib/platform_include/net/if.h#L20(removed as it was probably incorrect, see comment)@ivmarkov can you confirm the esp change?