Skip to content

Recognize mlibc environment#1488

Merged
NobodyXu merged 1 commit into
rust-lang:mainfrom
no92:managarm
Jun 30, 2025
Merged

Recognize mlibc environment#1488
NobodyXu merged 1 commit into
rust-lang:mainfrom
no92:managarm

Conversation

@no92

@no92 no92 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

This PR serves to upstream the mlibc environment so that the x86_64-unknown-managarm-mlibc target can be upstreamed into rustc (see rust-lang/rust#123319) after this PR appears in a tagged release (and rustc bumps its cc-rs version for bootstrap).

This is the triple upstreamed into LLVM (as of commit llvm/llvm-project@0f302f3), so no further changed are needed. Running the rustc_target_test with a rustc with this and the rustc PR applied succeeds, as do all other tests.

@no92

no92 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

The clippy warnings about format! look unrelated to this PR.

@NobodyXu NobodyXu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I've merged the clippy PR, can you do a rebase please?

@no92

no92 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Rebased on main.

@NobodyXu
NobodyXu merged commit 6f0dd80 into rust-lang:main Jun 30, 2025
73 checks passed
@no92
no92 deleted the managarm branch June 30, 2025 13:00
@github-actions github-actions Bot mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants