Skip to content

fix(util): constant type for Redox OS #17064

Merged
weihanglo merged 1 commit into
rust-lang:masterfrom
willnode:redox-port
Jun 1, 2026
Merged

fix(util): constant type for Redox OS #17064
weihanglo merged 1 commit into
rust-lang:masterfrom
willnode:redox-port

Conversation

@willnode
Copy link
Copy Markdown
Contributor

@willnode willnode commented Jun 1, 2026

What does this PR try to resolve?

This fixes compilation to Redox platform due to mode_t being i32. This patch has been used in Redox cargo fork downstream for years.

How to test and review this PR?

cargo install --git https://gitlab.redox-os.org/redox-os/redoxer.git
redoxer pkg curl
redoxer build --release

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 1, 2026

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Could you bump a patch version for cargo-util crate and update hte workspace Cargo.lock?

View changes since this review

@willnode willnode changed the title util: Fix constant type for Redox OS fix(util): constant type for Redox OS Jun 1, 2026
Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weihanglo weihanglo added this pull request to the merge queue Jun 1, 2026
Merged via the queue into rust-lang:master with commit abab377 Jun 1, 2026
31 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants