Allow attaching notes to PRs#778
Conversation
|
@JonathanBrouwer Let me know if the syntax (and web presentation) is fine for you :) |
|
This looks great, thanks! |
|
After this PR is merged we should make rust-timer set a note |
What note should it set? That a perf. benchmark was done on it? 🤔 Such PRs are already marked with |
My goal would be to be able to easily separate PRs that are rollup=never because of perf from other ones |
|
I see. I wonder if we should have some special marker for them then, e.g. just a note that says |
This PR makes it possible to attach a note to a PR, using one of the following three methods:
@bors r+ note=<note>@bors p=5 <note>@bors rollup=never <note>Note that I used an explicit
noteparameter in the approval command, because it already has two parametrs with arbitrary ordering (rollupandp), and it was a bit tricky making that work with taking the "rest" of the line as the note. But it could be improved in the future.The notes are then displayed when hovering on a PR on the queue page. PRs with a note are shown with an asterisk next to their PR number:

Fixes: #772