Skip to content

Allow attaching notes to PRs#778

Merged
Kobzol merged 4 commits into
rust-lang:mainfrom
Kobzol:pr-note
Jul 8, 2026
Merged

Allow attaching notes to PRs#778
Kobzol merged 4 commits into
rust-lang:mainfrom
Kobzol:pr-note

Conversation

@Kobzol

@Kobzol Kobzol commented Jul 8, 2026

Copy link
Copy Markdown
Member

This PR makes it possible to attach a note to a PR, using one of the following three methods:

  • @bors r+ note=<note>
  • @bors p=5 <note>
  • @bors rollup=never <note>

Note that I used an explicit note parameter in the approval command, because it already has two parametrs with arbitrary ordering (rollup and p), and it was a bit tricky making that work with taking the "rest" of the line as the note. But it could be improved in the future.

The notes are then displayed when hovering on a PR on the queue page. PRs with a note are shown with an asterisk next to their PR number:
image

Fixes: #772

@Kobzol

Kobzol commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@JonathanBrouwer Let me know if the syntax (and web presentation) is fine for you :)

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

This looks great, thanks!

@JonathanBrouwer

JonathanBrouwer commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

After this PR is merged we should make rust-timer set a note

@Kobzol

Kobzol commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

After this PR is merged we should make rust-timer set a note

What note should it set? That a perf. benchmark was done on it? 🤔 Such PRs are already marked with rollup=never.

@Kobzol Kobzol added this pull request to the merge queue Jul 8, 2026
Merged via the queue into rust-lang:main with commit e027f02 Jul 8, 2026
5 checks passed
@Kobzol Kobzol deleted the pr-note branch July 8, 2026 16:01
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

What note should it set? That a perf. benchmark was done on it? 🤔 Such PRs are already marked with rollup=never.

My goal would be to be able to easily separate PRs that are rollup=never because of perf from other ones

@Kobzol

Kobzol commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

I see. I wonder if we should have some special marker for them then, e.g. just a note that says perf, and bors could detect that and show e.g. a little stopwatch next to the PR row, or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support providing reason for rollup=never or rollup=iffy

2 participants