use cfg_select instead of cfg_if#763
Open
hkBst wants to merge 1 commit into
Open
Conversation
rust-cloud-vms
Bot
force-pushed
the
cfg-select
branch
from
dccc004 to
9e370ea
Compare
hkBst
commented
Jul 2, 2026
| // Everything else should doesn't know how to load native libraries. | ||
| } | ||
| _ => { | ||
| // Everything else doesn't know how to load native libraries. |
rust-cloud-vms
Bot
force-pushed
the
cfg-select
branch
from
9e370ea to
0b31e39
Compare
Member
Author
|
I don't see how I broke (macos-latest, nightly)... maybe the object point release will help... |
workingjubilee
requested changes
Jul 3, 2026
workingjubilee
left a comment
workingjubilee
left a comment
Member
There was a problem hiding this comment.
Not your problem exactly but this should not land before we fix #758 and cut a release as I do not want a further MSRV change to become a precondition for a safety-related update. Thus I am filing this comment so that in later triage it becomes obvious there is something to address (...outside this PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that cfg_select is stable since 1.95, we can replace cfg_if. One difference is that cfg_select needs one branch to match. Therefore an empty default branch is sometimes needed.