Skip to content

Manual weekly update to cargo-rbmt (to 0.5.1)#1005

Open
satsfy wants to merge 3 commits into
rust-bitcoin:masterfrom
satsfy:pr-1003
Open

Manual weekly update to cargo-rbmt (to 0.5.1)#1005
satsfy wants to merge 3 commits into
rust-bitcoin:masterfrom
satsfy:pr-1003

Conversation

@satsfy

@satsfy satsfy commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Supersedes #1003

The bump is straight to 0.5.1 to leverage a bug fix in the minor version.

The new rbmt 0.5.0 changeset modifies subcommands, breaking two CI jobs:

  • docsrs became docs, which by default is docs.rs mode and accepts --no-docsrs.
  • run now injects -p <name> for every workspace member. descriptor-fuzz uses old_miniscript dep.

@satsfy
satsfy force-pushed the pr-1003 branch 3 times, most recently from e3f7400 to 29c5824 Compare July 14, 2026 18:54
@satsfy
satsfy marked this pull request as draft July 14, 2026 21:01
@satsfy

satsfy commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Drafted this pr to wait on 0.5.1 benches fix for rbmt, which would render a commit in this PR obsolete.

@satsfy
satsfy force-pushed the pr-1003 branch 2 times, most recently from 9c3b153 to b505b70 Compare July 15, 2026 15:05
@satsfy

satsfy commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Hey @nyonson, I also had a problem with rbmt 0.5.0 about disk space. So the CI failure on 03891c4 was fixed with b505b70, in which I reduced the log volume with log discarding configs.

Is this correct? Or is there some objection to doing it?

@nyonson

nyonson commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

I don't know much about those log settings, but after a brief reading it seems sensible to me. I can't think off the top of my head what changed in 0.5.0 to cause more artifact output. In the past the Github image has also changed out from under us and caused disk space issues.

@nyonson

nyonson commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

I believe CARGO_PROFILE_TEST_DEBUG inherits from CARGO_PROFILE_DEV_DEBUG, so unless setting it to a different value than dev, I don't think it is necessary to set both?

@satsfy
satsfy force-pushed the pr-1003 branch 2 times, most recently from 530bc3e to 035ef24 Compare July 15, 2026 19:31
@satsfy

satsfy commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Great point, I kept only the one essential flag. Realized that the problem actually is not related to rbmt 0.5.0, but a pre-existing issue. It induced flaky CI and just happened to affect my previous run. I kept it included on this PR because it is small and targeted.

@satsfy
satsfy force-pushed the pr-1003 branch 2 times, most recently from ab89486 to c7196b1 Compare July 17, 2026 20:30
@satsfy
satsfy marked this pull request as ready for review July 17, 2026 22:00
@satsfy satsfy changed the title Manual weekly update to cargo-rbmt (to 0.5.0) Manual weekly update to cargo-rbmt (to 0.5.1) Jul 22, 2026
satsfy added 2 commits July 22, 2026 17:37
rbmt 0.5.0 removed the standalone docsrs subcommand and folded
docs.rs validation into docs, which manages its own toolchains.
Keep a single Docs job running cargo rbmt docs and drop Docsrs.
Cargo rbmt compiles the full feature matrix into one target dir,
which fills up runner disk. Drop debuginfo logs to save disk space.

This is a fix for a pre-existing CI flake.
@satsfy

satsfy commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Force push removed the docrs job as discussed in rust-bitcoin/rust-bitcoin#6547. Now bumping to rbmt 0.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants