fix: normalize headings with markdown link targets - #14
Merged
Conversation
Recognize and normalize changelog headings that carry a markdown link target — reference-style `## [Unreleased][unreleased]` and inline `## [Unreleased](unreleased)` — on both the Unreleased and versioned sections. SECTION_RE now tolerates an optional `[ref]`/`(url)` after the bracketed heading text; the target is discarded since link refs are regenerated on release. Replaces the 1.5.0 handling of the reversed `## (Unreleased)[unreleased]` shape, which no tool emits.
Split the combined heading regex into three simpler regexes to cut cyclomatic complexity below Sonar's threshold and use \d instead of [0-9]. Parameterize the three near-identical unreleased-heading tests into one test.each block.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog headings that carry a markdown link target are now recognized and normalized:
## [Unreleased][unreleased]## [Unreleased](unreleased)This applies to both the
Unreleasedheading and versioned sections (e.g.## [1.2.3](url) - 2025-01-01). The link target is dropped on parse; link references are regenerated on release.Replaces the 1.5.0 handling of the reversed
## (Unreleased)[unreleased]shape, which no tool emits.