Fix unselectable no-prefix option in tag-prefix selector - #11
Merged
Conversation
The tag-prefix picker was a type-the-value prompt whose no-prefix option had an empty-string key. Empty input was already claimed by "use the default" (v), so the no-prefix row was unreachable. Replace askSelect with an arrow-key TUI (up/down + enter, wrap-around, Ctrl-C/ESC abort) plus a "custom prefix..." row for free-text entry. Non-TTY/piped input falls back to a numbered list so pipes and CI keep working; that fallback also makes the empty option reachable by number. Add tests/unit/prompt.test.ts covering the real selector over fake streams (interactive and numbered paths, including the empty and custom rows) — the regression coverage the old design lacked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a repo with no existing tags (or mixed prefixed/bare tags),
pubvprompts for a tag prefix:The
(empty)/ no-prefix row was unselectable.askSelectwas a type-the-value prompt and that option's key is the empty string — but empty input (pressing Enter) was already claimed by "use the default" (v), and no other token mapped to''. So the no-prefix option could never be chosen.Fix
--tag-prefix).1..n, Enter = default) so pipes don't hang; this alone also makes the empty option reachable.Tests
New
tests/unit/prompt.test.tsdrives the realcreatePrompt().selectover fake streams — interactive (down+enter → empty, enter → default, up-wrap → custom) and numbered (number, empty → default, custom) — the regression coverage the old design lacked.FakePrompt.selectgains the optionalcustomparam; existing tests unchanged.Local: lint, typecheck, build, and full suite (220 tests) all pass.