.github/with-docker: make compatible with podman - #1167
Merged
Merged
Conversation
palinatolmach
approved these changes
Sep 21, 2026
palinatolmach
left a comment
Member
There was a problem hiding this comment.
lgtm, just a couple of minor notes:
- the comment in the
dockerjob points to.github/actions/with-dockerfor the reasoning behind the pre-runrm --force, butaction.ymlhas no comment there; --rmondocker runis now redundant due to the explicit teardown, so I believe it can be dropped, but should be harmless to keep too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import the changes from runtimeverification/evm-semantics#2881 and runtimeverification/evm-semantics#2880 to add compatibility for Podman.
Change the
kontrol-ci-integrationcontainer names to unique ones instead:kontrol-ci-cse,kontrol-ci-e2e, andkontrol-ci-expected-output.Adding the
--ulimit nofile=65536:65536flag to the build command in the Docker Tests stage.