Skip to content

.github/with-docker: make compatible with podman - #1167

Merged
anvacaru merged 3 commits into
masterfrom
anvacaru/ci-podman-compat
Sep 28, 2026
Merged

anvacaru merged 3 commits into
masterfrom
anvacaru/ci-podman-compat

Conversation

@anvacaru

@anvacaru anvacaru commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Import the changes from runtimeverification/evm-semantics#2881 and runtimeverification/evm-semantics#2880 to add compatibility for Podman.

Change the kontrol-ci-integration container names to unique ones instead: kontrol-ci-cse, kontrol-ci-e2e, and kontrol-ci-expected-output.
Adding the --ulimit nofile=65536:65536 flag to the build command in the Docker Tests stage.

@palinatolmach palinatolmach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple of minor notes:

  • the comment in the docker job points to .github/actions/with-docker for the reasoning behind the pre-run rm --force, but action.yml has no comment there;
  • --rm on docker run is now redundant due to the explicit teardown, so I believe it can be dropped, but should be harmless to keep too.

@anvacaru
anvacaru merged commit 0898ff7 into master Sep 28, 2026
14 checks passed
@anvacaru
anvacaru deleted the anvacaru/ci-podman-compat branch September 28, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants