fix: return empty list when template list offset exceeds count#279
Open
pranavgundu wants to merge 1 commit into
Open
fix: return empty list when template list offset exceeds count#279pranavgundu wants to merge 1 commit into
pranavgundu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
template listreturned the full unsliced result when--offsetwas greater than or equal to the number of templates after filtering. Pagination check usedopts.Offset < len(allTemplates), so out of range offsets fell through and re-returned everything.[]Template{}immediately whenOffset >= len(allTemplates).Before fix
runpodctl template list --type official→ 13 templatesrunpodctl template list --type official --offset 13→ returned all 13 again (expected[])runpodctl template list --type official --offset 99999→ returned all 13 (expected[])After fix
--offset 13→[]--offset 99999→[]--offset 5→ 8 results (in-range still correct)Test plan