Fix dependency vulnerabilities#220
Conversation
TimPietruskyRunPod
left a comment
There was a problem hiding this comment.
Reviewed as part of today's triage. Direction is good — security fix + the requirements.txt introduction is a nice cleanup. Two questions before I can approve:
1. Bumping runpod to the 1.9 line
This isn't motivated in the PR description. The previous install line was just runpod (unpinned, latest). What specifically prompted the floor? If it's just for the cryptography resolution, that should come through transitively without us pinning runpod directly. If there's a known incompatibility with older runpod we should call it out so we don't accidentally regress.
Concern: there may be a boto3 1.40 regression breaking S3 uploads to non-AWS providers like Cloudflare R2 and GCS. We're pinning boto3<1.40 in #224 — please check whether runpod>=1.9 drags in a newer botocore/boto3 that would override that pin. If so we'll need a compatible constraint.
2. Changeset
This repo uses Changesets. Could you add a .changeset/fix-dependency-vulnerabilities.md so the security fix gets called out in the release notes? Something like:
---
"worker-comfyui": patch
---
fix: address dependency vulnerabilities — pin `cryptography==46.0.7` (CVE remediation), bump `runpod` floor to 1.9.x, switch handler dependency install to `requirements.txt`, bump `@changesets/cli` to 2.30 (transitive picomatch patch).Once those are addressed I'll happily approve.
Summary
Fixes currently reproducible dependency vulnerabilities in the worker dependency manifests:
1.9linecryptography==46.0.7, which contains fixes for the currently reportedcryptographyCVEsrequirements.txt, so the manifest fix is actually used by the image build@changesets/cliand the lockfile sopicomatchresolves to patched2.3.2Validation
pnpm audit --jsonpip-audit -r requirements.txtpnpm install --frozen-lockfilebash -n src/*.sh scripts/*.shpython3 -m json.tool package.jsonpython3 -m json.tool test_input.jsonpython3 -m compileall handler.py srcdocker buildx bake --print base