Claude/add lora loading node w xg9u#219
Open
czzs wants to merge 15 commits into
Open
Conversation
Includes comfyui-kjnodes, comfyui-videohelpersuite, comfyui-frame-interpolation, and comfyui_essentials nodes. Uses base image with no pre-loaded models for network volume usage.
…oo9-h2AMk Add custom Dockerfile for video/animation workflows
Builds and pushes Dockerfile.custom to Docker Hub on: - Push to main when Dockerfile.custom changes - Manual workflow dispatch Tags images with both 'latest' and commit SHA.
Updated base image version for ComfyUI worker.
…oo9-h2AMk Claude/explain codebase mkd3ltpfzd90poo9 h2 a mk
…oo9-h2AMk Fix: Free up disk space before Docker build
…oo9-h2AMk Add ComfyUI-GIMM-VFI node for video frame interpolation
The ws.recv() call previously blocked indefinitely with no timeout, causing RunPod jobs to fail with "WebSocket message timeout after 60.0 seconds" on heavy workloads like video frame interpolation. - Add WEBSOCKET_MESSAGE_TIMEOUT env var (default 600s / 10 minutes) - Set ws.settimeout() after initial connect and after reconnect - On timeout, probe ComfyUI HTTP health before resuming the wait; fail fast if the server has become unreachable https://claude.ai/code/session_01TXa8rubsUoz56PV36fLRpS
On timeout, before deciding whether to keep waiting or fail, poll ComfyUI's /queue endpoint to check if the job is still actively running or pending. This matches the fix applied to the regular GPU server's generation_worker.py. Timeout handler now follows this decision tree: 1. ComfyUI HTTP unreachable → fail immediately 2. Job still in /queue (running/pending) → continue waiting 3. Queue check failed (network blip) → continue (benefit of doubt) 4. Job NOT in queue and NOT completed → fail with clear error https://claude.ai/code/session_01TXa8rubsUoz56PV36fLRpS
Claude/fix websocket timeout h gi xc
Install the LoRA model loading node from sourceful-official that supports loading LoRA models by URL directly. https://claude.ai/code/session_01V44ZJUxEKQn8HMUPvgDSXg
The node is available on the Comfy Registry, so use comfy-node-install instead of git clone. https://claude.ai/code/session_01V44ZJUxEKQn8HMUPvgDSXg
TimPietruskyRunPod
requested changes
Jun 2, 2026
Contributor
TimPietruskyRunPod
left a comment
TimPietruskyRunPod
left a comment
There was a problem hiding this comment.
Thanks for the contribution, but this PR is doing too many unrelated things at once and needs to be split before it can be merged.
The PR title is "add lora loading node" but the diff actually contains:
- A new
Dockerfile.customwith hardcoded custom nodes (comfyui-kjnodes,comfyui-videohelpersuite,comfyui-frame-interpolation,comfyui_essentials,comfyui-gimm-vfi,loadloramodelonlywithurl) - A new
.github/workflows/build-custom.ymlthat pushes to${{ secrets.DOCKERHUB_USERNAME }}/runpod-comfy-worker(not the officialrunpod/worker-comfyuinamespace) - A new
WEBSOCKET_MESSAGE_TIMEOUTenv var + handler change for socket recv timeout (this looks like it might be useful, but it's totally unrelated to the title) - An empty PR description (no motivation, no changeset)
- No tests, and no validation that the lora node actually loads correctly
I can't merge any of this as-is:
- The custom
Dockerfile.custombelongs in the user's own fork. It's not a generic improvement to the official worker — it's a specific bundle of nodes for one use case. - The
build-custom.ymlpushing to a different Docker Hub namespace is definitely not appropriate for this repo. - The
WEBSOCKET_MESSAGE_TIMEOUTchange might actually be valuable. If you want to land that, please open a separate PR with: just that change, a changeset, a PR body explaining the motivation (which heavy workload made you hit the silent timeout?), and ideally a reproduction.
Requesting changes — please close this and open focused PRs for the parts you actually want upstreamed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issues closed
Changeset