Skip to content

use comfy --skip-prompt instead /usr/bin/yes |#178

Open
yuturiy wants to merge 1 commit into
runpod-workers:mainfrom
yuturiy:patch-1
Open

use comfy --skip-prompt instead /usr/bin/yes |#178
yuturiy wants to merge 1 commit into
runpod-workers:mainfrom
yuturiy:patch-1

Conversation

@yuturiy
Copy link
Copy Markdown

@yuturiy yuturiy commented Oct 11, 2025

Motivation

cleaner code

Copy link
Copy Markdown
Contributor

@TimPietruskyRunPod TimPietruskyRunPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup — comfy --skip-prompt is the modern replacement for the /usr/bin/yes | workaround.

Two small things before merge:

  1. Changeset: this repo uses Changesets. Please add .changeset/use-comfy-skip-prompt.md:

    ---
    "worker-comfyui": patch
    ---
    
    chore: use `comfy --skip-prompt` instead of piping `yes` for ComfyUI install in the Dockerfile. Equivalent behavior, cleaner intent.
  2. Rebase: this branch is behind main. Once you add the changeset, please pull/rebase so we get a clean merge.

Note this is the same pattern called out in scripts/comfy-node-install.sh:11 (set +e; comfy node install --mode=remote "$@") — for consistency you could update that too if you want, but it's optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants