use comfy --skip-prompt instead /usr/bin/yes |#178
Open
yuturiy wants to merge 1 commit into
Open
Conversation
Contributor
TimPietruskyRunPod
left a comment
There was a problem hiding this comment.
Good cleanup — comfy --skip-prompt is the modern replacement for the /usr/bin/yes | workaround.
Two small things before merge:
-
Changeset: this repo uses Changesets. Please add
.changeset/use-comfy-skip-prompt.md:--- "worker-comfyui": patch --- chore: use `comfy --skip-prompt` instead of piping `yes` for ComfyUI install in the Dockerfile. Equivalent behavior, cleaner intent.
-
Rebase: this branch is behind
main. Once you add the changeset, please pull/rebase so we get a clean merge.
Note this is the same pattern called out in scripts/comfy-node-install.sh:11 (set +e; comfy node install --mode=remote "$@") — for consistency you could update that too if you want, but it's optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cleaner code