Skip to content

ci(project): run CI on pull requests with any base - #158

Open
ross-rl wants to merge 1 commit into
mainfrom
ci/pr-trigger-any-base
Open

ci(project): run CI on pull requests with any base#158
ross-rl wants to merge 1 commit into
mainfrom
ci/pr-trigger-any-base

Conversation

@ross-rl

@ross-rl ross-rl commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

What

Drop the branches: [main] filter from the pull_request trigger in ci.yml, so check (Node 22 and 24: lint/format, typecheck, build, test) and audit run on every pull request regardless of its base. push stays scoped to main.

smoke-tests.yml keeps its branches: [main] trigger: its only job is already gated on startsWith(github.head_ref, 'release-please--branches--main') and it drives real devboxes, so broadening it would add cost without adding signal.

Why

Stacked PRs currently get no build, typecheck or test result at all — only conventional-commit. #155, #156 and #157 each landed with a one-item check list, which reads to a human reviewer as "verified" when nothing was actually run. Local verification is not a reproducible required check.

Cost is bounded: the concurrency group already cancels superseded runs per ref, and check/audit are a few minutes on a bun install.

Checklist

  • PR title follows <type>(<scope>): <description> format (see above)
  • bun run check passes (lint + format)
  • bun run build passes
  • bun run test passes
  • SDK documentation updated (if applicable) — workflow-only change

Restricting the pull_request trigger to base main means a stacked PR gets no
build, typecheck or test result — only the PR-title check — so an empty check
list reads as verified. Smoke tests keep their main-only trigger: they are
already scoped to release-please branches and consume real devboxes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@reflex-loop

reflex-loop Bot commented Jul 29, 2026

Copy link
Copy Markdown

Reflex agent status: Completed

The agent completed its work.

This PR was created by Reflex.

View the agent run →

This comment updates in place as the agent works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant