ci(project): run CI on pull requests with any base - #158
Open
ross-rl wants to merge 1 commit into
Open
Conversation
Restricting the pull_request trigger to base main means a stacked PR gets no build, typecheck or test result — only the PR-title check — so an empty check list reads as verified. Smoke tests keep their main-only trigger: they are already scoped to release-please branches and consume real devboxes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
✅ Reflex agent status: Completed The agent completed its work. This PR was created by Reflex. This comment updates in place as the agent works. |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
branches: [main]filter from thepull_requesttrigger inci.yml, socheck(Node 22 and 24: lint/format, typecheck, build, test) andauditrun on every pull request regardless of its base.pushstays scoped tomain.smoke-tests.ymlkeeps itsbranches: [main]trigger: its only job is already gated onstartsWith(github.head_ref, 'release-please--branches--main')and it drives real devboxes, so broadening it would add cost without adding signal.Why
Stacked PRs currently get no build, typecheck or test result at all — only
conventional-commit. #155, #156 and #157 each landed with a one-item check list, which reads to a human reviewer as "verified" when nothing was actually run. Local verification is not a reproducible required check.Cost is bounded: the concurrency group already cancels superseded runs per ref, and
check/auditare a few minutes on a bun install.Checklist
<type>(<scope>): <description>format (see above)bun run checkpasses (lint + format)bun run buildpassesbun run testpasses