Update GearForge - #14905
Merged
runelite-github-app[bot] merged 2 commits intoAug 10, 2026
Merged
Conversation
|
This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates GearForge to
3e6a315.Mostly correctness work on the combat model, after checking it against the wiki calculator's own implementation and finding a number of effects missing or wrong.
Gear effects that were absent
VAMPYREconstant where the data spells three tiers.Effects that were wrong
Magic spell selection
Magic assumed Ice Barrage for every setup. 1,219 monsters have an elemental weakness worth half again in both accuracy and damage, so the strongest spell was the wrong answer for over a third of the game. The spell is now chosen from the target, which also makes the elemental tomes meaningful.
Tests: 211, all passing.
🤖 Generated with Claude Code