Skip to content

Update GearForge - #14905

Merged
runelite-github-app[bot] merged 2 commits into
runelite:masterfrom
marcushill13:gearforge-scrollbar
Aug 10, 2026
Merged

Update GearForge#14905
runelite-github-app[bot] merged 2 commits into
runelite:masterfrom
marcushill13:gearforge-scrollbar

Conversation

@marcushill13

@marcushill13 marcushill13 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Updates GearForge to 3e6a315.

Mostly correctness work on the combat model, after checking it against the wiki calculator's own implementation and finding a number of effects missing or wrong.

Gear effects that were absent

  • Crystal armour, which does nothing without a crystal bow but is worth +30% accuracy and +15% damage with one. Without it the optimiser preferred rune knives with a shield over a bow of faerdhinen.
  • Enchanted bolts — all six enchantments and their dragon variants, including the immunities. These cannot be written as a damage multiplier, so the engine now carries a damage distribution.
  • Powered staves and tridents, whose maximum comes from the Magic level rather than a spell.
  • The salve amulet's plain and enchanted forms, and the Soul Wars and Emir's Arena copies of the imbued ones.
  • The vampyre banes, which had never fired: the attribute was a single VAMPYRE constant where the data spells three tiers.
  • Obsidian set, berserker necklace, amulet of avarice, Efaritay's aid, colossal blade, ratbane weapons, brimstone ring, crystal blessing, chaos gauntlets, twinflame staff, eclipse atlatl.

Effects that were wrong

  • Darklight and silverlight had a 60% damage bonus the game does not give them; it applies to the attack roll only.
  • Best-in-slot ties were broken by item name, so the alphabet decided between items with identical DPS.
  • The optimiser kept only five candidates per slot, which fell short of an exhaustive search on 15 of 15 test banks. Raised to twenty, where it matches.

Magic spell selection

Magic assumed Ice Barrage for every setup. 1,219 monsters have an elemental weakness worth half again in both accuracy and damage, so the strongest spell was the wrong answer for over a third of the game. The spell is now chosen from the target, which also makes the elemental tomes meaningful.

Tests: 211, all passing.

🤖 Generated with Claude Code

@runelite-github-app

runelite-github-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@runelite-github-app
runelite-github-app Bot merged commit ef625b8 into runelite:master Aug 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant