Update Slayer Best in Bank: coherent loadouts and task fixes

[FreeArcanes]

Summary

Updates Slayer Best in Bank to source commit aa31d3677ca671b66b5bc5ce5c79a72af5571be3.

Turael/Aya skipping and point boosting

• adds a persistent Turael/Aya skipping / boosting checkbox directly to the side panel
• covers all 24 current Turael/Aya assignments and deliberately selects low-level task variants instead of bosses
• prefers an owned toxic blowpipe, falls back to the best compatible owned ranged weapon, and adds a dwarf multicannon only on supported routes
• includes an Expeditious bracelet while speed mode is active

Preparation and strategy corrections

• applies the documented Oathplate-over-Torva ordering for Aquanites, Dark beasts, Duke Sucellus, Vardorvis, and Skotizo without forcing Oathplate into tie or Torva-first cases
• ensures regular tasks prefer ordinary Super restores and limits blighted restores to confirmed Wilderness tasks
• adds configurable bonecrusher and ash sanctifier preparation
• allows Expeditious and Slaughter bracelets to be packed together
• expands Max cape support across home, spell, fairy-ring, and Kourend travel preferences

Venator targeting

• resolves both Venator and Venators through the dedicated Vampyre profile
• rejects Noxious halberd and other weapons that cannot damage the NPC
• prioritizes Sunspear and Hallowed Flail for melee and scores Efaritay's aid's target-specific bonuses

Coherent loadout scoring

• selects weapon, off-hand, ammo, and supporting armour as a compatible package instead of isolated slots
• prevents incomplete Void hybrids, including the reported Slayer helmet + Bandos chestplate + Elite void robe setup
• accounts for Bowfa/Crystal bow armour bonuses, Inquisitor crush synergy, and Eclipse atlatl's Melee Strength scaling
• separates protection-prayer and no-prayer defensive methods for Bloodveld, Aberrant spectres, Suqahs, and Jellies

Review follow-up fixes

• rebuilds and re-scores every weapon-dependent armour slot when an alternate loadout tier changes weapons
• prevents Bowfa/Crystal, Eclipse atlatl, and Inquisitor bonuses or explanations from leaking into an incompatible fallback tier
• models the additional 1% non-mace Inquisitor full-set accuracy and damage bonus only when the helm, body, and legs are all equipped
• preserves pinned items, mandatory protection, compatible ammunition and off-hands, and low-risk choices during package rebuilding

Why

The prior isolated-slot scorer could recommend an item with attractive defensive stats even when its set bonus was impossible in the selected Slayer loadout. It could also miss weapon/armour synergies and let defensive weighting override offensive gear while a protection prayer already nullified the incoming attack.

A final review found that alternate tiers could retain supporting-armour scores from their previous weapon and that non-mace Inquisitor setups omitted the complete-set bonus. The follow-up commit rebuilds the dependent package after a weapon swap and treats the Inquisitor bonus as a whole-loadout effect.

User impact

Players receive usable whole-loadout recommendations rather than incompatible mixtures. Alternate tiers no longer carry stale Crystal, atlatl, or Inquisitor scoring after a weapon swap. Complete Inquisitor crush setups are compared using their real set effect, while partial sets receive no extra bonus. Regular tasks no longer pull Wilderness-only restores, Venators receive valid Vampyre gear, and Turael/Aya users have a dedicated fast-task workflow.

Validation

• source PRs: Improve Slayer Wiki scoring and add Turael speed mode FreeArcanes/slayer-best-in-bank#10 and Fix coherent Slayer loadout and Venator scoring FreeArcanes/slayer-best-in-bank#11
• clean source test run: 216 tests across 23 suites, zero failures
• new regressions cover weapon swaps rebuilding supporting armour and clearing stale explanations
• new regressions cover complete versus partial non-mace Inquisitor sets
• all 24 current Turael/Aya assignments have regression coverage
• every current Slayer profile is audited against incomplete Void recommendations
• end-to-end regressions cover Bloodveld/Void, Bowfa/Crystal, Eclipse atlatl, Inquisitor crush, and Venator target rules
• Plugin Hub change remains limited to plugins/slayer-best-in-bank
• git diff --check passes

[runelite-github-app]

slayer-best-in-bank: eabf212eeac010c1bc1f0ce56e3a0a2762c5b098..aa31d3677ca671b66b5bc5ce5c79a72af5571be3

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details